Repository navigation
Conversation
This was referenced Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Clover's noisy-block previews must preserve committed recurrent state and read a bidirectional block. The existing Hygon providers cannot execute that model. The companion InfiniLM integration uses these kernels directly from C++, with optional expert budgeting/live-row reuse during preview and full causal replay for commit.
Dependency: InfiniTensor/InfiniRT#52. The build was also checked against the installed Hygon SDK.
Type of Change
feat— new operators / backend capabilitiesbuild— installed API generationtest— numerical/state and JIT metadata checksPlatforms Affected
WITH_HYGON, added to this template)Smoke Test Result
Hygon BW/gfx936, DTK 26.04, Torch 2.10.0, Triton 3.5.0, BF16 data and FP32 recurrent state:
The rebased build passed 62 wrapper/JIT/public-header and Clover tests. The required CPU/Hygon smoke selection passed: 121 passed, 43 skipped (inactive providers), 9485 deselected. Build, tooling and checked-in tests are documented in
docs/clover-hygon.md.tests/native/clover_workspace_smoke.cppexercises workspace-bearing providers through the native public API. Missing workspaces are rejected before launch. The original unguarded Python functional invocation failed; that failed prototype is not included as a passing result.Test Results on Supported Platforms
Benchmark / Performance Impact
The companion native InfiniLM campaign uses real Clover-35B-A3B-Preview weights, BF16 TP2, 32 short prompts repeated three times, concurrency one and a common OpenAI chat client. All 96 requests per lane completed. Visible output tokens are retokenized consistently; padded diffusion usage counters are excluded.
Measured integration throughput after upstream sync: native baseline 28.57 tok/s; frontier stride 38.47; expert budget/live reuse 28.70; joint 39.92; local SGLang Clover port 5.88. These are end-to-end integration results, not isolated operator speedups. The measurement record retains all requests, failures, warmups and rejected candidates. Final smoke repairs also cover strided casts and preserving the vendor HIP driver during autotuning.
Separate traces contain GPU events on both TP devices. Live-row kernels occur only in the joint path; summed routed-MoE GPU duration decreases from 1339 ms to 721 ms in the representative profiled request. Profiling time is excluded from throughput and summed device durations are not wall time.
Notes for Reviewers
Preview state is read-only. Causal replay remains exact to the specified recurrent equations; live-row reuse is an opt-in approximation controlled by the LM. The H100 DP/EP sequence-parallel communication pipeline is not ported here.
INFINI_OPS_DECLARATIONSexposes unsupported APIs for compilation/capability queries; it does not create fallback providers. Preserve explicit workspace lifetime and same-stream ordering. The code-generation comment-default issue found during bring-up was already fixed upstream; the branch keeps the upstream implementation.Source provenance, API alignment, supported layouts and licenses are recorded in the operator guide and
THIRD_PARTY.txt. Cross-platform accelerator CI is still needed for the shared tooling changes.