Skip to content

fix(queries): handle list filter values without silently using CONTAINS #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rudra337-lgtm wants to merge 1 commit into from
Closed

fix(queries): handle list filter values without silently using CONTAINS #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion fairgraph/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,16 @@ def get_query_filter_property(property, context, filter: Any) -> QueryProperty:
filter_obj = None
else:
# we have a filter value for this property
if isinstance(filter, Regex):
if isinstance(filter, list) and filter:
if all(isinstance(item, Regex) for item in filter):
op = "REGEX"
elif all(isinstance(item, Equals) for item in filter):
op = "EQUALS"
elif property.types[0] in (int, float, bool, datetime, date):
op = "EQUALS"
else:
op = "CONTAINS"
elif isinstance(filter, Regex):
op = "REGEX"
elif isinstance(filter, Equals):
op = "EQUALS"
Expand Down