Repository navigation
fix(queries): handle list filter values without silently using CONTAINS - #157
Closed
rudra337-lgtm wants to merge 1 commit into
Closed
rudra337-lgtm wants to merge 1 commit into
rudra337-lgtm wants to merge 1 commit into
Conversation
Member
|
Thanks for working on this! This was unfortunate timing, as a solution was already in the works - #150 has now been fixed by #156, which supports lists of filter values: each value becomes its own filter, and a result must match all of them. So I'm closing this PR. I appreciate you taking the time, and contributions on other open issues are very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150. Handle list of Regex/Equals filter values in get_query_filter_property so op is derived correctly. Fixes silent CONTAINS with list values. Also guards link-typed startswith for lists.