Skip to content

perf: Catch typed condition errors without a context manager #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
khvn26 wants to merge 1 commit into
base: perf/06-in-list
Choose a base branch
from
Draft

perf: Catch typed condition errors without a context manager #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions flag_engine/segments/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import re
import typing
import warnings
from contextlib import suppress
from functools import cached_property, lru_cache, partial, wraps

import jsonpath_rfc9535
Expand Down Expand Up @@ -649,14 +648,17 @@ def inner(
segment_value: typing.Optional[str],
context_value: typing.Union[ContextValue, semver.Version],
) -> bool:
with suppress(TypeError, ValueError):
# A `try` statement rather than `contextlib.suppress`, which costs more
# than the comparison itself: this runs for every typed condition.
try:
if isinstance(context_value, str) and is_semver(segment_value):
context_value = semver.Version.parse(
context_value,
)
match_value = get_casting_function(context_value)(segment_value)
return func(context_value, match_value)
return False
except (TypeError, ValueError):
return False

return inner

Expand Down