Repository navigation
Conversation
Every typed condition evaluated entered a `contextlib.suppress` context manager, which costs more than the comparison itself. The errors are now caught with a `try` statement, about 175 ns less per condition.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every typed condition evaluated entered a
contextlib.suppresscontext manager, which costs more than the comparison itself. The errors are now caught with atrystatement, which costs nothing when nothing is raised.Effect: ~280 → ~100 ns per typed condition, so about 5–11% on segment-heavy evaluations.
Part of a stack of local evaluation performance PRs; see #353 for the stack and combined results.
perf/allholds the whole stack for benchmarking.