Skip to content

London | 26-ITP-Sep | Diana Ausiejute | Sprint 3 | Dead Code #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ausiejute wants to merge 5 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sep | Diana Ausiejute | Sprint 3 | Dead Code #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad794ba
Remove instances of unreachable and redundant code - exercise 1
ausiejute Oct 18, 2026
c7874fc
Remove instances of unreachable and redundant code - exercise 2
ausiejute Oct 18, 2026
0c7a6f9
Remove more unnecessary code - Exercise 2
ausiejute Oct 19, 2026
a494ad0
Added incorrect deletions back
ausiejute Oct 21, 2026
4348268
Add the console.log line back in
ausiejute Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,10 @@

let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";

const greetingMessage = sayHello(greeting, testName);

console.log(greetingMessage); // 'hello, Aman!'

@madhuranakate madhuranakate Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the function being called ? if you run this code, can you see any output ?

@ausiejute ausiejute Oct 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right!, if there's no associated test, I wouldn't know if it does without it. So if we did have a test for this function, would it be correct to delete the console log method? (i would guess it would depend on the broader context?)

console.log(greetingMessage);
9 changes: 2 additions & 7 deletions dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand All @@ -24,5 +20,4 @@ function countAndCapitalisePets(petsArr) {
}

const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);

console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log

@madhuranakate madhuranakate Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this console log line is removed, how can you see the output ?

@ausiejute ausiejute Oct 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, i removed too much

console.log(countedPetsStartingWithH);
Loading