Repository navigation
Conversation
ausiejute
added
📅 Sprint 3
madhuranakate
added
Review in progress
|
|
||
| const greetingMessage = sayHello(greeting, testName); | ||
|
|
||
| console.log(greetingMessage); // 'hello, Aman!' |
There was a problem hiding this comment.
is the function being called ? if you run this code, can you see any output ?
Author
There was a problem hiding this comment.
right!, if there's no associated test, I wouldn't know if it does without it. So if we did have a test for this function, would it be correct to delete the console log method? (i would guess it would depend on the broader context?)
madhuranakate
suggested changes
Oct 21, 2026
|
|
||
| const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH); | ||
|
|
||
| console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log |
There was a problem hiding this comment.
if this console log line is removed, how can you see the output ?
madhuranakate
added
Reviewed
ausiejute
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Completed both exercises, removing dead code.