Repository navigation
fix(web): keep seat management state with its organization - #3446
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching organizations on the billing page keeps unsaved seat quantities and an open cancellation dialog when both organizations have the same current seat count. A cancellation started for one organization can also finish after switching and reset edits or invalidate subscription data for the new organization.
Key the stateful seat form by organization ID. Switching remounts its local form and mutation observer, clears its pending debounce through the existing cleanup, and keeps old mutation callbacks bound to their original organization. Ordinary rerenders and server seat-count updates retain their existing behavior.
Validation: six new mounted cases use the real TanStack Query/mutation hooks and seat calculations with controlled server actions. All three organization-switch regressions fail before the fix; the ordinary rerender, updated total and successful submit controls pass. Scoped Biome, CI YAML parsing and diff checks pass. The regression suite is included in the explicit web CI list.
Reproduce:
cd apps/web && bun run test __tests__/unit/seat-management-organization.test.ts __tests__/unit/billing-page.test.ts __tests__/unit/signed-baa-card.test.ts.Server actions and the dialog shell are controlled; no live billing change was made. Full web typecheck/build and a deployed browser replay were not run. No dependencies, pricing rules or server mutation APIs change.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Keeps seat edits and the cancellation dialog with their organization.
Reviews (1) · Last reviewed commit: "fix(web): reset seat management when swi..." · Reviewed by Greptile