Repository navigation
fix(web): keep General Settings forms with their organization - #3447
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching organizations on General Settings retains the previous name draft, domain verification indicator, and open domain setup/removal dialogs. The name can then be saved against the new organization, and a removal started earlier can later clear the new organization's verification indicator.
Key the shared settings card by organization ID so its child forms and mutation observers belong to that organization. One boundary resets the name, domain, icon and access-domain controls together. Ordinary rerenders within the same organization retain unsaved edits, and old mutation completions affect their original, unmounted form.
Validation: all 26 focused tests pass: seven new mounted settings cases, 14 Signed BAA cases and five billing-page cases. Six new regressions fail before the fix; the same-organization edit/save control passes. Tests exercise the real name/domain components and TanStack mutation hooks with controlled actions and dialog shells. Scoped Biome, CI YAML parsing and diff checks pass; the new suite is added to web CI.
Reproduce:
cd apps/web && bun run test __tests__/unit/organization-settings-ownership.test.ts __tests__/unit/signed-baa-card.test.ts __tests__/unit/billing-page.test.ts.No deployed browser replay or full web typecheck/build was run. No server APIs or dependencies change. Related #3446 fixes the separate seat-management form on Billing; this change covers General Settings and does not touch that component.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Keys the General Settings card by organization ID so drafts, dialogs, and local verification state reset when users switch organizations.
Reviews (1) · Last reviewed commit: "fix(web): reset organization settings wh..." · Reviewed by Greptile