Repository navigation
chore(ci): move CI and Docker to Node 26 LTS (#244) - #247
Merged
Merged
Conversation
Node 26 is Active LTS (since 28 Oct 2026) and Node 22 is in Maintenance with EOL April 2027. CI and Docker were both on 22 while frontend/package.json pins @types/node ^26, so the type definitions described an API the build never ran on. - Dockerfile frontend-builder: node:22-alpine -> node:26-alpine, with the pinned multi-arch index digest updated to match. The tag alone would not have moved it: the base image is pinned by digest, so this would have silently kept building on Node 22. - ci.yml and audit.yml: node-version 22 -> 26. One thing the issue asked to confirm, and it did not hold: **node:26-alpine no longer bundles corepack**, so `corepack enable && corepack prepare pnpm@10.32.1` fails with "corepack: not found" (verified by running the image). pnpm is now installed with `npm install -g pnpm@10.32.1` — same pinned version, same reproducibility, no dependency on a bundled shim. @types/node stays at ^26.6.5: the lockfile already resolves 26.6.6, so the range is honest without a lockfile change. Verified: - `docker build --target frontend-builder` on node:26-alpine: pnpm 10.32.1 installs, `pnpm install --frozen-lockfile` and `pnpm build` both succeed. - `make build` (frontend build + single Go binary) succeeds. - node:26-alpine is a multi-arch OCI index with linux/amd64 and linux/arm64/v8, so the buildx matrix is unaffected.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Dockerfile base image:
frontend-buildermoves tonode:26-alpinewith the digest bumped alongside the tag (sha256:8996bb58…). I confirmed that digest is the currentnode:26-alpineindex on Docker Hub and carries bothlinux/amd64andlinux/arm64/v8, so the tag and the pin actually agree — the failure mode where the tag moves but the digest keeps resolving Node 22 is not present here. - pnpm install path:
corepack enable && corepack prepare pnpm@10.32.1 --activatebecomesnpm install -g pnpm@10.32.1. The stated reason checks out: corepack has not been distributed with Node since 25.0.0, so the old line would have failed the frontend stage outright. The pin still matchespackageManagerinfrontend/package.jsonand the version CI installs viapnpm/action-setup, so Docker and Actions stay in step. - CI Node version:
setup-nodegoes to26in bothci.ymlandaudit.yml. Neither job obtains pnpm from corepack, so neither needed a companion edit — the bump is self-contained. This PR's owncheckandbuildruns already exercised the new toolchain successfully.
No stale Node 22 references remain anywhere in the tree (node:22, Node 22, node-version: 22 all return nothing), and dependabot.yml has no ignore rules that would fight the new tag. No actionable findings.
deepseek-v4.1-flash | 𝕏
kpalang
pushed a commit
to kpalang/calnode
that referenced
this pull request
Nov 12, 2026
Audit has been red on main since the Calnode#247 merge, but Calnode#247 is unrelated: this is a newly published standard library advisory, not a change in our code. GO-2026-6859: net/http@go1.26.10, fixed in go1.26.11 `go.mod` pins `toolchain go1.26.10`, so every CI run resolves the affected stdlib and the clean-security-scan claim fails. Reproduced locally with govulncheck under 1.26.10, and the same scan under 1.26.11 reports "No vulnerabilities found". Bump only the toolchain directive. The `go` line stays at 1.26.0, since a patch-level stdlib fix should not raise the minimum language version. The Dockerfile's builder image is golang:1.27.3 and was not flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #244.
What changed
Dockerfilefrontend-buildernode:22-alpine@sha256:fe4f…node:26-alpine@sha256:8996….github/workflows/ci.ymlnode-version: 2226.github/workflows/audit.ymlnode-version: 2226Two things worth calling out
The base image is pinned by digest, so the tag change alone would have done nothing. The Dockerfile pins the multi-arch index digest with the tag beside it for readers. Changing only
node:22-alpine→node:26-alpinewould have kept building on Node 22 while the file appeared to say otherwise. The digest is updated too (sha256:8996bb…, confirmed as an OCI index withlinux/amd64andlinux/arm64/v8).The corepack step the issue asked to verify does not survive this.
node:26-alpineno longer bundles corepack — running the image givescorepack: not found, so the existingcorepack enable && corepack prepare pnpm@10.32.1 --activatewould have failed the build. pnpm is now installed with:RUN npm install -g pnpm@10.32.1Same pinned version, same reproducibility, no dependency on a bundled shim. This is the one change here that isn't a version bump.
@types/nodeleft at^26.6.5: the lockfile already resolves26.6.6, so the types are honest without touching the lockfile.Verified
docker build --target frontend-builderonnode:26-alpine: pnpm 10.32.1 installs,pnpm install --frozen-lockfileandpnpm buildboth succeed.make build: frontend build plus the single Go binary, succeeds.node:26-alpineindex carries bothlinux/amd64andlinux/arm64/v8, so the buildx matrix is unaffected.The full multi-arch Docker publish only runs on tag pushes, so that leg is CI-only on merge — the frontend stage it exercises is the one changed here.
🤖 Generated with Claude Code