Skip to content

chore(ci): move CI and Docker to Node 26 LTS (#244) - #247

Merged
shockalotti merged 1 commit into
mainfrom
chore/node-26-lts
Nov 11, 2026
Merged

shockalotti merged 1 commit into
mainfrom
chore/node-26-lts

Conversation

@shockalotti

Copy link
Copy Markdown
Contributor

Closes #244.

What changed

File Before After
Dockerfile frontend-builder node:22-alpine@sha256:fe4f… node:26-alpine@sha256:8996…
.github/workflows/ci.yml node-version: 22 26
.github/workflows/audit.yml node-version: 22 26

Two things worth calling out

The base image is pinned by digest, so the tag change alone would have done nothing. The Dockerfile pins the multi-arch index digest with the tag beside it for readers. Changing only node:22-alpine → node:26-alpine would have kept building on Node 22 while the file appeared to say otherwise. The digest is updated too (sha256:8996bb…, confirmed as an OCI index with linux/amd64 and linux/arm64/v8).

The corepack step the issue asked to verify does not survive this. node:26-alpine no longer bundles corepack — running the image gives corepack: not found, so the existing corepack enable && corepack prepare pnpm@10.32.1 --activate would have failed the build. pnpm is now installed with:

RUN npm install -g pnpm@10.32.1

Same pinned version, same reproducibility, no dependency on a bundled shim. This is the one change here that isn't a version bump.

@types/node left at ^26.6.5: the lockfile already resolves 26.6.6, so the types are honest without touching the lockfile.

Verified

  • docker build --target frontend-builder on node:26-alpine: pnpm 10.32.1 installs, pnpm install --frozen-lockfile and pnpm build both succeed.
  • make build: frontend build plus the single Go binary, succeeds.
  • node:26-alpine index carries both linux/amd64 and linux/arm64/v8, so the buildx matrix is unaffected.

The full multi-arch Docker publish only runs on tag pushes, so that leg is CI-only on merge — the frontend stage it exercises is the one changed here.

🤖 Generated with Claude Code

Node 26 is Active LTS (since 28 Oct 2026) and Node 22 is in Maintenance with EOL
April 2027. CI and Docker were both on 22 while frontend/package.json pins
@types/node ^26, so the type definitions described an API the build never ran on.

- Dockerfile frontend-builder: node:22-alpine -> node:26-alpine, with the pinned
  multi-arch index digest updated to match. The tag alone would not have moved it:
  the base image is pinned by digest, so this would have silently kept building on
  Node 22.
- ci.yml and audit.yml: node-version 22 -> 26.

One thing the issue asked to confirm, and it did not hold: **node:26-alpine no
longer bundles corepack**, so `corepack enable && corepack prepare pnpm@10.32.1`
fails with "corepack: not found" (verified by running the image). pnpm is now
installed with `npm install -g pnpm@10.32.1` — same pinned version, same
reproducibility, no dependency on a bundled shim.

@types/node stays at ^26.6.5: the lockfile already resolves 26.6.6, so the range
is honest without a lockfile change.

Verified:
- `docker build --target frontend-builder` on node:26-alpine: pnpm 10.32.1 installs,
  `pnpm install --frozen-lockfile` and `pnpm build` both succeed.
- `make build` (frontend build + single Go binary) succeeds.
- node:26-alpine is a multi-arch OCI index with linux/amd64 and linux/arm64/v8, so
  the buildx matrix is unaffected.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Dockerfile base image: frontend-builder moves to node:26-alpine with the digest bumped alongside the tag (sha256:8996bb58…). I confirmed that digest is the current node:26-alpine index on Docker Hub and carries both linux/amd64 and linux/arm64/v8, so the tag and the pin actually agree — the failure mode where the tag moves but the digest keeps resolving Node 22 is not present here.
  • pnpm install path: corepack enable && corepack prepare pnpm@10.32.1 --activate becomes npm install -g pnpm@10.32.1. The stated reason checks out: corepack has not been distributed with Node since 25.0.0, so the old line would have failed the frontend stage outright. The pin still matches packageManager in frontend/package.json and the version CI installs via pnpm/action-setup, so Docker and Actions stay in step.
  • CI Node version: setup-node goes to 26 in both ci.yml and audit.yml. Neither job obtains pnpm from corepack, so neither needed a companion edit — the bump is self-contained. This PR's own check and build runs already exercised the new toolchain successfully.

No stale Node 22 references remain anywhere in the tree (node:22, Node 22, node-version: 22 all return nothing), and dependabot.yml has no ignore rules that would fight the new tag. No actionable findings.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash | 𝕏

@shockalotti
shockalotti merged commit 282e2a7 into main Nov 11, 2026
14 checks passed
kpalang pushed a commit to kpalang/calnode that referenced this pull request Nov 12, 2026
Audit has been red on main since the Calnode#247 merge, but Calnode#247 is unrelated: this is a newly
published standard library advisory, not a change in our code.

    GO-2026-6859: net/http@go1.26.10, fixed in go1.26.11

`go.mod` pins `toolchain go1.26.10`, so every CI run resolves the affected stdlib and the
clean-security-scan claim fails. Reproduced locally with govulncheck under 1.26.10, and the
same scan under 1.26.11 reports "No vulnerabilities found".

Bump only the toolchain directive. The `go` line stays at 1.26.0, since a patch-level stdlib
fix should not raise the minimum language version. The Dockerfile's builder image is
golang:1.27.3 and was not flagged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move CI and Docker to Node 26 LTS, and align @types/node

1 participant