Skip to content

fix(build): move the Go toolchain to 1.26.11 for GO-2026-6859 - #252

Merged
shockalotti merged 1 commit into
mainfrom
fix/go-toolchain-1.26.11
Nov 11, 2026
Merged

shockalotti merged 1 commit into
mainfrom
fix/go-toolchain-1.26.11

Conversation

@shockalotti

Copy link
Copy Markdown
Contributor

Main's Audit has been red since the #247 merge, but #247 (Node 26) is unrelated. This is a newly published standard library advisory.

GO-2026-6859: net/http@go1.26.10
  Fixed in:    net/http@go1.26.11

go.mod pins toolchain go1.26.10, so every CI run resolves the affected stdlib and the clean-security-scan claim fails.

Change

One line: toolchain go1.26.10 → toolchain go1.26.11. The go directive stays at 1.26.0, because a patch-level stdlib fix should not raise the minimum language version.

The Dockerfile builder is golang:1.27.3 and govulncheck did not flag it, so it is untouched.

Verification

Reproduced the failure locally with govulncheck under exactly 1.26.10, then re-ran under 1.26.11:

No vulnerabilities found.
Your code is affected by 0 vulnerabilities.

go build ./... passes under 1.26.11, and the internal/mailer and internal/handler suites pass. This PR's own Audit run is the real gate, since audit now runs on pull requests.

Audit has been red on main since the #247 merge, but #247 is unrelated: this is a newly
published standard library advisory, not a change in our code.

    GO-2026-6859: net/http@go1.26.10, fixed in go1.26.11

`go.mod` pins `toolchain go1.26.10`, so every CI run resolves the affected stdlib and the
clean-security-scan claim fails. Reproduced locally with govulncheck under 1.26.10, and the
same scan under 1.26.11 reports "No vulnerabilities found".

Bump only the toolchain directive. The `go` line stays at 1.26.0, since a patch-level stdlib
fix should not raise the minimum language version. The Dockerfile's builder image is
golang:1.27.3 and was not flagged.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The go.mod bump fixes the Audit gate, but the release image is still compiled with Go 1.27.3, which GO-2026-6859 also covers (fixed in 1.27.4). That pin should move in the same PR.

Reviewed changes

  • go.mod toolchain pin — toolchain go1.26.10 → go1.26.11 for GO-2026-6859, leaving the go 1.26.0 language directive alone.

⚠️ GO-2026-6859 is still open in the shipped container image

Dockerfile:35 pins golang:1.27.3-alpine, and the advisory's ranges are 0 → 1.26.11 and 1.27.0-0 → 1.27.4, so 1.27.3 sits inside the affected window just as 1.26.10 did. With only go.mod moved, the clean-security-scan claim goes green while the image operators pull still contains the vulnerable net/http — and this is not a theoretical path here, since roughly sixty handlers call http.MaxBytesReader, the function behind the race.

Technical details
# Builder image must move with the module toolchain

## Affected sites
- `Dockerfile:35` — `FROM ... golang:1.27.3-alpine@sha256:d200d2dd76b03a99b52651fd1325aff7dcd35422c35c01bac56571b0507f3deb AS builder`. The static binary compiled in this stage is the one the release image runs, so its stdlib is Go 1.27.3.
- `CHANGELOG.md:15` — `[Unreleased]` carries no `### Security` entry. The previous stdlib-CVE toolchain bump (`CHANGELOG.md:338`) records both pins in one bullet: "Go toolchain 1.26.9, and the Docker image builds with Go 1.27.2. Both close 12 published Go standard-library vulnerabilities…".
- `audit.yml:125` — the green `govulncheck` step attests only the toolchain it runs under (now 1.26.11). `docker-publish.yml` builds the PR image with a syft SBOM and no vulnerability scan, so CI has no signal on the builder's Go version at all.

## Required outcome
- The released image is produced by a Go toolchain outside the advisory's affected ranges, and the CHANGELOG records the fix with its advisory ID, matching how earlier bumps were documented.

## Suggested approach
- `Dockerfile:35` → `golang:1.27.4-alpine@sha256:0a5f7fe796599ff487605987432e7619ae45beeb2fba4c2ce0b907879932aebf` (the current index digest for `1.27.4-alpine`; tag and digest have to move together, since the digest is what actually decides the build).
- Add a `### Security` bullet under `[Unreleased]` naming GO-2026-6859 / CVE-2026-97054 and both pins.

## Open questions for the human
- Is 1.27.4 fine for the builder, or does anything in the tree need to stay on the 1.26 line? `go.mod`'s `go 1.26.0` keeps the language version at 1.26 either way, so this should be inert for compilation.

Pullfrog  | Fix it ➔ | View workflow run | Using deepseek-v4.1-flash | 𝕏

@shockalotti
shockalotti merged commit 0aeb1ef into main Nov 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant