Skip to content

Greek i18n - #194

Merged
shockalotti merged 9 commits into
Calnode:mainfrom
MinosChatzidakis:greek_i18n
Nov 2, 2026
Merged

shockalotti merged 9 commits into
Calnode:mainfrom
MinosChatzidakis:greek_i18n

Conversation

@MinosChatzidakis

Copy link
Copy Markdown
Contributor

Added greek translation

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Minor wording fixes in the Greek strings, plus a docs update.

Reviewed changes

  • New Greek locale — internal/i18n/locales/el.json adds all 179 keys with the same key set and order as en.json. go test ./internal/i18n/ passes, including the node/Intl CLDR cross-check (weekday/month abbreviations, 12h clock) and the printf-verb guard, so structure is verified.
  • .gitignore — adds calnode-data/, the Docker volume name used in DEPLOY.md/README.md. Unrelated to the translation but harmless.

ℹ️ Supported-locale docs still say nine

The translation itself is structurally sound, but the places that enumerate the shipped locales are now stale the moment this merges.

Technical details
# Locale-count documentation is stale after adding `el`

## Affected sites
- `README.md:203-205` — says "9 languages" and lists nine; Greek is missing.
- `CONTRIBUTING.md:77` — `en es fr fr-CA de it pt nl sv`.
- `docs/ARCHITECTURE.md:1232` — "ships **9 locales**" list.
- `CLAUDE.md:143` — `Ships en es fr fr-CA de it pt nl sv`.
- `docs/ARCHITECTURE.md:1334` — the register paragraph lists formal/informal per locale and omits Greek (this translation uses formal plural forms, e.g. `θα θέλατε`, `Σας`).

## Required outcome
- The shipped-locale count and list match `SupportedLocales()` (10 after this PR).
- The register paragraph records Greek's formal register so a future reader does not assume those docs are authoritative.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using deepseek-v4.1-flash | 𝕏

Comment thread internal/i18n/locales/el.json Resolved
Comment thread internal/i18n/locales/el.json Resolved
Comment thread internal/i18n/locales/el.json Resolved
Comment thread internal/i18n/locales/el.json Resolved
Comment thread internal/i18n/locales/el.json Resolved
Comment thread internal/i18n/locales/el.json Resolved
Comment thread internal/i18n/locales/el.json Resolved
MinosChatzidakis and others added 7 commits November 1, 2026 16:58
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Prior translation review fully addressed — all seven flagged Greek strings are corrected in the new commits: assistant_error (Παρακαλούμε), link_expired_text (έγκυρο), rescheduling and reschedule_failed_error (single-accent επαναπρογραμματισμός), assistant_iteration_cap (single period, lowercase after em dash), calendar_degraded_notice (είναι), and directory_person_subtitle (Κράτηση ώρας).
  • Structure still intact — key set and order continue to match en.json, and go test ./internal/i18n/ passes, including the CLDR Intl cross-check and printf-verb parity guards.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash | 𝕏

@shockalotti
shockalotti merged commit c67d99d into Calnode:main Nov 2, 2026
10 checks passed
@MinosChatzidakis
MinosChatzidakis deleted the greek_i18n branch November 6, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants