Repository navigation
Greek i18n - #194
Merged
Merged
Greek i18n#194
Conversation
Contributor
There was a problem hiding this comment.
ℹ️ Minor wording fixes in the Greek strings, plus a docs update.
Reviewed changes
- New Greek locale —
internal/i18n/locales/el.jsonadds all 179 keys with the same key set and order asen.json.go test ./internal/i18n/passes, including the node/IntlCLDR cross-check (weekday/month abbreviations, 12h clock) and the printf-verb guard, so structure is verified. .gitignore— addscalnode-data/, the Docker volume name used inDEPLOY.md/README.md. Unrelated to the translation but harmless.
ℹ️ Supported-locale docs still say nine
The translation itself is structurally sound, but the places that enumerate the shipped locales are now stale the moment this merges.
Technical details
# Locale-count documentation is stale after adding `el`
## Affected sites
- `README.md:203-205` — says "9 languages" and lists nine; Greek is missing.
- `CONTRIBUTING.md:77` — `en es fr fr-CA de it pt nl sv`.
- `docs/ARCHITECTURE.md:1232` — "ships **9 locales**" list.
- `CLAUDE.md:143` — `Ships en es fr fr-CA de it pt nl sv`.
- `docs/ARCHITECTURE.md:1334` — the register paragraph lists formal/informal per locale and omits Greek (this translation uses formal plural forms, e.g. `θα θέλατε`, `Σας`).
## Required outcome
- The shipped-locale count and list match `SupportedLocales()` (10 after this PR).
- The register paragraph records Greek's formal register so a future reader does not assume those docs are authoritative.deepseek-v4.1-flash | 𝕏
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Prior translation review fully addressed — all seven flagged Greek strings are corrected in the new commits:
assistant_error(Παρακαλούμε),link_expired_text(έγκυρο),reschedulingandreschedule_failed_error(single-accentεπαναπρογραμματισμός),assistant_iteration_cap(single period, lowercase after em dash),calendar_degraded_notice(είναι), anddirectory_person_subtitle(Κράτηση ώρας). - Structure still intact — key set and order continue to match
en.json, andgo test ./internal/i18n/passes, including the CLDRIntlcross-check and printf-verb parity guards.
deepseek-v4.1-flash | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added greek translation