Repository navigation
feat: MythicMobs bosses and minions for phase finales - #56
Open
tastybento wants to merge 2 commits into
Open
tastybento wants to merge 2 commits into
tastybento wants to merge 2 commits into
Conversation
A finale can name a MythicMobs mob with `mythic-boss` (and `mythic-level`). It is spawned through BentoBox's MythicMobs hook on the same tick, then handled like any other boss: leash, boss bar, player-only damage, player scaling and mercy. It keeps its own health and size unless the phase file sets them. `boss` becomes an optional fallback used when MythicMobs is missing or does not know the mob; with no fallback the finale is waived so an island is never sealed behind a boss that cannot appear. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HBXcjarmPKNsWM5LHDzSw2
Member
Author
|
AOneBlock counterpart: BentoBoxWorld/AOneBlock#571 |
A finale's `mythic-minions` section (MythicMobs type: count) spawns MythicMobs mobs alongside the boss, at `mythic-level`. They are finale minions like the vanilla ones: no block changes, cleared when the fight ends. They work with a vanilla or a MythicMobs boss. If MythicMobs is missing or does not know a type, that type is tried once, logged and skipped; the fight goes on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HBXcjarmPKNsWM5LHDzSw2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Requested on Discord: let a phase finale use a MythicMobs mob as its boss.
Phase file
How it works
MythicMobsHookwith a 0-tick delay, so it spawns synchronously and there's still no compile-time dependency on MythicMobs.healthandscaledefault to 0 for a mythic boss, which means the mob keeps its MythicMobs values. Player scaling and mercy are applied to that base health. Setting either one in the phase file overrides it. Ahealth: 0now means "the mob's own" for vanilla bosses too.bossis optional whenmythic-bossis set. If the MythicMob can't be spawned, the vanilla boss is used. If there's no fallback, the finale is waived (same as any other spawn failure), so an island is never sealed behind a boss that can't appear.mythic-minionsspawns MythicMobs mobs alongside the boss atmythic-level. They work with a vanilla or a MythicMobs boss and sit next tominions. They're handled like vanilla minions: they can't change blocks and are cleared when the fight ends. If MythicMobs is missing or doesn't know a type, that type is tried once, logged and skipped, and the fight goes on.mythic-boss,mythic-levelandmythic-minionsback out.0_plains.ymlare updated.Tests
The
FinaleListenertests cover: a mythic boss being summoned and keeping its own health and size, killing it as the win, the fallback when the mob is unknown or MythicMobs isn't installed, waiving when there's no fallback, the hook throwing, a spawned entity that isn't living, mythic minions (spawned, registered, cleared), mythic minions with a vanilla boss, and a missing minion type being tried only once. The hook call is isolated inspawnMythicEntityand stubbed with a spy, because MythicMobs isn't on the test classpath.OneBlocksManagerTest3covers parsing. The full suite passes (796 tests).Not tested on a live server with MythicMobs yet. A matching PR is coming for AOneBlock.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HBXcjarmPKNsWM5LHDzSw2