Skip to content

feat: MythicMobs bosses and minions for phase finales - #571

Open
tastybento wants to merge 2 commits into
developfrom
feature/mythic-finale-boss
Open

tastybento wants to merge 2 commits into
developfrom
feature/mythic-finale-boss

Conversation

@tastybento

@tastybento tastybento commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Requested on Discord: let a phase finale use a MythicMobs mob as its boss.

Phase file

finale:
  mythic-boss: SkeletonKing     # MythicMobs mob type id
  mythic-level: 3               # optional, default 1
  boss: WITHER_SKELETON         # optional fallback if MythicMobs is missing or doesn't know the mob
  mythic-minions:               # MythicMobs type: count, spawned at mythic-level
    SkeletalMinion: 3
  name: '<gold>The Skeleton King'
  drops:
    DIAMOND: 4

How it works

  • The mob is spawned through BentoBox's MythicMobsHook with a 0-tick delay, so it spawns synchronously and there's still no compile-time dependency on MythicMobs.
  • After that it's an ordinary finale boss: leash, boss bar, player-only damage, health scaling per player and mercy after a loss, minions, drops and commands. Its own MythicMobs skills, AI and drops still apply.
  • health and scale default to 0 for a mythic boss, which means the mob keeps its MythicMobs values. Player scaling and mercy are applied to that base health. Setting either one in the phase file overrides it. A health: 0 now means "the mob's own" for vanilla bosses too.
  • boss is optional when mythic-boss is set. If the MythicMob can't be spawned, the vanilla boss is used. If there's no fallback, the finale is waived (same as any other spawn failure), so an island is never sealed behind a boss that can't appear.
  • mythic-minions spawns MythicMobs mobs alongside the boss at mythic-level. They work with a vanilla or a MythicMobs boss and sit next to minions. They're handled like vanilla minions: they can't change blocks and are cleared when the fight ends. If MythicMobs is missing or doesn't know a type, that type is tried once, logged and skipped, and the fight goes on.
  • Saving phases writes mythic-boss, mythic-level and mythic-minions back out.
  • The finale docs at the top of 0_plains.yml are updated.

Tests

The FinaleListener tests cover: a mythic boss being summoned and keeping its own health and size, killing it as the win, the fallback when the mob is unknown or MythicMobs isn't installed, waiving when there's no fallback, the hook throwing, a spawned entity that isn't living, mythic minions (spawned, registered, cleared), mythic minions with a vanilla boss, and a missing minion type being tried only once. The hook call is isolated in spawnMythicEntity and stubbed with a spy, because MythicMobs isn't on the test classpath. OneBlocksManagerTest3 covers parsing. The full suite passes (626 tests).

Not tested on a live server with MythicMobs yet. Same change as BentoBoxWorld/ChunkBlock#56, since the finale code is shared.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HBXcjarmPKNsWM5LHDzSw2

A finale can name a MythicMobs mob with `mythic-boss` (and `mythic-level`).
It is spawned through BentoBox's MythicMobs hook on the same tick, then
handled like any other boss: leash, boss bar, player-only damage, player
scaling and mercy. It keeps its own health and size unless the phase file
sets them. `boss` becomes an optional fallback used when MythicMobs is
missing or does not know the mob; with no fallback the finale is waived so
an island is never sealed behind a boss that cannot appear.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HBXcjarmPKNsWM5LHDzSw2
A finale's `mythic-minions` section (MythicMobs type: count) spawns
MythicMobs mobs alongside the boss, at `mythic-level`. They are finale
minions like the vanilla ones: no block changes, cleared when the fight
ends. They work with a vanilla or a MythicMobs boss. If MythicMobs is
missing or does not know a type, that type is tried once, logged and
skipped; the fight goes on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HBXcjarmPKNsWM5LHDzSw2
@tastybento tastybento changed the title feat: MythicMobs mobs as phase finale bosses feat: MythicMobs bosses and minions for phase finales Nov 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant