Repository navigation
Isolate Fieldset object warnings from caller-owned state - #59
Merged
Merged
Conversation
Fixes #58 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fieldset now clones caller-supplied
PropertyInterfacewarnings and renders them locally, matching the existing controls' clone-and-render pattern. Generated warning IDs no longer mutate the original warning object. String warning markup and the boundary around arbitrary children remain unchanged; callers still own member-control associations.Added regression coverage for unchanged caller state, stable repeated rendering with one warning, warning reuse across fieldsets and a text input with independent IDs, string/object markup, empty warnings, and unchanged arbitrary child controls. Documented the warning behavior and association boundary in README.md.
Validation on PHP 8.5.2:
composer test -- --filter FieldsetTestbefore the fix: failed as expected (2 mutation failures).composer test -- --filter 'FieldsetTest|ControlGuidanceTest': passed (82 tests, 1422 assertions).composer production: passed (PHPCS, PHPStan, and full PHPUnit suite: 200 tests, 1832 assertions).git --no-pager diff --checkandgit --no-pager diff --cached --check: passed.List of issues fixed
Fixes #58