Repository navigation
feat: add scheduleWorkflowType and deprecate scheduleWorkflowName - #22
Merged
Merged
Conversation
Part of zigflow/zigflow#617. scheduleWorkflowName names a workflow type, not a name, since document.name became document.workflowType (zigflow/zigflow#340). - scheduleWorkflowType: the workflow type a schedule starts. - scheduleWorkflowName: kept, marked deprecated, so existing files still pass. - A schedule no longer requires either key in the schema. Zigflow defaults the target to document.workflowType; only the runtime can tell when that does not apply (every top-level task is a Do task), so it reports that case. Signed-off-by: Yash B Joshi <68319416+YJ-928@users.noreply.github.com>
mrsimonemms
requested changes
Oct 28, 2026
mrsimonemms
left a comment
mrsimonemms
left a comment
Contributor
There was a problem hiding this comment.
Thank you. I think we should get rid of the deprecated tag entirely as no releases yet.
No release of Studio uses it yet. document.metadata is open, so files that still set it keep validating. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yash B Joshi <68319416+YJ-928@users.noreply.github.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scheduleWorkflowNamenames a workflow type, not a name, sincedocument.namebecamedocument.workflowType(zigflow/zigflow#340).scheduleWorkflowType: new key, the workflow type a schedule starts.scheduleWorkflowName: kept and markeddeprecated: true, so existing files still validate.document.workflowType; only the runtime can tell when that does not apply (every top-level task is a Do task), so zigflow reports that case at load. That change follows in a zigflow PR once this merges.Related issue
Relates to zigflow/zigflow#617 (the zigflow PR closes it).
How to test
go test ./...TestSchema_ScheduleNeedsNoWorkflowKeyreplacesTestSchema_ScheduleRequiresScheduleWorkflowName. Run againstmain, it fails for a schedule with no metadata, metadata without a key, andscheduleWorkflowType(3 of 4 cases); it passes here.schema.jsonandschema.yamlwere regenerated by the pre-commit hooks, which all pass.Checklist
Fixes #...,Closes #...orRelates to #...