Repository navigation
Conversation
~=2.7 caps python-dateutil below 3. The test suite passes unchanged with python-dateutil 2.9.0.post0, 3.0.0 and 4.0.0, including the isoparse based datetime literals.
Owner
|
Thanks for opening this! Changes look good. I'd just like to see the test suite pass with the new major versions of python-dateutil that will be accepted. If you want to add that, that'd be great otherwise if you give me a a week or two, I should be able to handle it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python-dateutil~=2.7means>=2.7,<3. python-dateutil 3.0.0 (21 Oct) and 4.0.0 (1 Nov) are out, so rule-engine can't be installed next to anything that needs them.rule-engine uses
dateutil.parser.isoparsefor datetime literals andtz.tzlocal/tz.tzutc. dateutil 4.0 madeisoparsereject malformed numeric fields (e.g.2014- 4-21), which doesn't affect valid literals. This changes the requirement to>=2.7,<5in both[project]and[build-system].python -m unittest tests: 710 tests, OK (32 skipped) with python-dateutil 2.9.0.post0, 3.0.0 and 4.0.0 (Python 3.12).I didn't touch
uv.lock: my uv version rewrote the whole file.uv syncin CI re-resolves it, oruv locklocally will refresh therequires-distentry.