Repository navigation
Enable Ruby LSP on-type formatting by default - #351
Draft
JacobNWolf wants to merge 1 commit into
Draft
JacobNWolf wants to merge 1 commit into
JacobNWolf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Ruby LSP on-type formatting by default by removing the extension's
onTypeFormatting: falseworkaround for #38. Ruby LSP enables the feature by default; user-supplied initialization options, including an explicit opt-out, pass through unchanged.Release prerequisites
Keep this PR in draft until both fixes have shipped:
Projects using a bundled or otherwise pinned Ruby LSP must update to a gem release containing the fix.
Validation
cargo test --locked --offline— 79 tests passed.cargo check --locked --offline --target wasm32-wasip2— passed.cargo fmt --checkandgit diff --check— passed.Manual verification with released fixes is pending:
def fooordo |x|inserts an indented body and closingend, keeping the cursor in the body.# hellocontinues the comment with one#prefix.lsp.ruby-lsp.initialization_options.enabledFeatures.onTypeFormatting: falsestill disables the feature.