Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 4eacdd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
abharms
force-pushed
the
codex/chapter-picker-normal-tab-order
branch
from
October 24, 2026 22:23
e0a9ef0 to
cf7e1d9
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm exec turbo build --filter=@youversion/platform-react-ui --forceVITEST_BROWSER=chromium pnpm --filter @youversion/platform-react-ui exec vitest run --project storybook src/components/bible-chapter-picker.shadow-isolation.stories.tsxpnpm --filter @youversion/platform-react-ui exec vitest run --project unit src/components/bible-chapter-picker.test.tsx src/components/bible-picker-shadow-isolation.test.tsxpnpm lintJira
YPE-6344
The PR appears safe to merge; no blocking issues remain.Summary
The chapter picker search field now follows the normal DOM tab order.
No new actionable issues were found. Builds and browser tests were not run during this review.
Reviews (2) · Last reviewed commit: "test(ui): preserve chapter picker keyboa..." · Reviewed by Greptile