Repository navigation
Conversation
BigRoy
requested review from
iLLiCiTiT
and
a lite review from Copilot
and removed request for
Copilot
November 2, 2026 13:19
Member
Author
|
This should be implemented the way we discussed @iLLiCiTiT |
iLLiCiTiT
reviewed
Nov 2, 2026
| def get_user( | ||
| username: str | None = None, | ||
| own_attributes: bool = False, | ||
| attrib: bool = True, |
Member
There was a problem hiding this comment.
Suggested change
| attrib: bool = True, | |
| fill_attrib: bool = True, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
get_userhas a newattribargument. Withattrib=Falseit doesn't fill missing user attributes with their default values, which saves the request for attribute schemas. Default isTrue, so behavior doesn't change.Requested in ynput/ayon-launcher#346, which needs only the username.
Additional info
get_usermakes 1 request instead of 2 withattrib=False.loginandcreate_workfile_info(server older than 1.1.3) use only the username, so they now callget_user(attrib=False).own_attributesworks the same with either value.Testing notes:
pytest tests/test_get_user_attrib.py(no server needed).