Skip to content

Fix: xgenerator reports memory overlap to avoid in-place assignment corruption - #2936

Open
Tyagiquamar wants to merge 1 commit into
xtensor-stack:masterfrom
Tyagiquamar:fix-xgenerator-overlap-2819
Open

Tyagiquamar wants to merge 1 commit into
xtensor-stack:masterfrom
Tyagiquamar:fix-xgenerator-overlap-2819

Conversation

@Tyagiquamar

Copy link
Copy Markdown

Fixes #2819. xgenerator's overlapping_memory_checker_traits returned false unconditionally, so assignment from an xgenerator reading its resized target (e.g. xt::concatenate into itself) could read uninitialized memory. Report true so a temporary is used. Root cause analysis in BYTEASK.md.

@Tyagiquamar
Tyagiquamar force-pushed the fix-xgenerator-overlap-2819 branch from 80a1441 to e8acbeb Compare October 12, 2026 12:50
@codspeed

codspeed Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

⚠️ 1 benchmark measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. This result is not comparable, so it counts as unchanged.

Preventing compiler optimizations

✅ 255 untouched benchmarks


Comparing Tyagiquamar:fix-xgenerator-overlap-2819 (e8acbeb) with master (d9a57b6)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoiding temporary fails with xt::concatenate

1 participant