Repository navigation
Respect the existing deadline when waiting for a partial batch - #60
Merged
wolph merged 1 commit intoOct 18, 2026
Merged
Conversation
wolph
added a commit
that referenced
this pull request
Oct 18, 2026
Owner
|
Thank you for the fix and the thorough tests! Waiting a full interval again for every item was never the intent, so this makes I've made one small change on top in 7cdd759: an item that arrives exactly at the deadline still joins the batch it was waiting on, since the 4.1.2 tests pin that, and the batch flushes at the deadline instead of an interval later. Beyond that everything is merged as it is. |
Owner
|
I've created a new release (v4.1.3) which includes your fix, thanks again for the help :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59.
abatcherwaits a full interval for each next item, even when a nonempty batch already has a deadline. With interval10 and arrivals0 and8, a blocked next item delays the batch until18. The strict deadline comparison also postpones a batch whose last item arrives exactly at10 until20.Use the remaining deadline for a nonempty batch, clamped to zero, and flush when the deadline is reached. Empty batches retain a full wait so an expired idle deadline cannot cause a busy loop. Existing resets after time/size flushes and pending-source cancellation are preserved. The docstring and changelog describe the timing correction.
Eight deterministic regressions cover arrivals before/on the deadline, numeric/timedelta intervals, and interval-only/size+interval batching. The existing fake-clock test now states both expected batch sequences explicitly: its at-deadline case flushes at equality rather than including the next item.
Validation:
AI assistance was used for investigation, implementation, tests, review and this description. No local PyPy/macOS or full interpreter-matrix claim. This fixes the requested wait and deadline comparison; it cannot guarantee scheduling latency on a blocked event loop.