Repository navigation
internal: refuse a second session request - #1315
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
RFC 4254 sec 6.5 lets only one shell, exec or subsystem request succeed per channel. DoChannelRequestSession() now refuses any request after the first grant without asking a callback, so the granted session and its command stand. - a refusal before any grant leaves the channel with no command - ssh.h documents the refusal; wolfsshd's own check is defence in depth - regress.c sends a second exec, shell and subsystem after a granted exec, and a second exec over a generic-callback grant - unit.c expects a shell after an exec to be refused and checks that a refused exec's command is scrubbed
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1315
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 3 of 5 in-scope changed file(s) opened by the reviewer; not opened: apps/wolfsshd/wolfsshd.c, wolfssh/ssh.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 4254 sec 6.5 lets only one shell, exec or subsystem request succeed per channel. The server now refuses any later one without asking a callback, so the granted session and its command stand.