Repository navigation
agent: check GetUint32 when reading message sizes - #1311
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
AgentReadMessage() and wolfSSH_AGENT_RelayChannel() now check the return from GetUint32() when reading an agent message's length prefix, like the other callers do. Issue: CID-656509
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes correctly propagate parser errors without altering successful behavior.
0 open findings
What changed in this PR
Checks GetUint32() results when parsing agent message lengths, addressing CID-656509.
Changes:
- Propagates parsing failures in
AgentReadMessage(). - Exits relay processing if message-length parsing fails.
| File | Description |
|---|---|
src/agent.c |
Handles previously ignored GetUint32() results. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1311
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the return from GetUint32() at the two agent call sites that ignored it, matching the other callers. Neither could fail, since both already confirm four bytes are available.
Issue: CID-656509