Repository navigation
keytools: allow linking against an installed wolfSSL - #936
Open
mattia-moffa wants to merge 1 commit into
Open
mattia-moffa wants to merge 1 commit into
mattia-moffa wants to merge 1 commit into
Conversation
Until now, the keytools could only build against the lib/wolfssl submodule. This allows building them using an installed wolfssl. The changes are mostly just in the build system, but sign.c has some changes to avoid using mp_* functions, which are not usually exported in the wolfssl shared object. Instead of doing that, we now sign to DER and split into r/s.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Switching wolfSSL build modes can silently reuse incompatible or outdated build artifacts.
1 open finding
What changed in this PR
Enables key tools to use an installed wolfSSL while preserving fixed-width ECC signatures.
Changes:
- Adds installed-library build configuration and documentation.
- Replaces direct multiprecision ECC handling with public DER conversion APIs.
- Validates required wolfSSL features at compile time.
| File | Description |
|---|---|
tools/keytools/sign.c |
Updates ECC signing and configuration checks. |
tools/keytools/keygen.c |
Adds wolfSSL feature validation. |
tools/keytools/Makefile |
Adds installed wolfSSL linking mode. |
docs/Signing.md |
Documents installed-library builds. |
docs/compile.md |
Links to the new instructions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, the keytools could only build against the lib/wolfssl submodule. This allows building them using an installed wolfssl.
The changes are mostly just in the build system, but sign.c has some changes to avoid using mp_* functions, which are not usually exported in the wolfssl shared object. Instead of doing that, we now sign to DER and split into r/s.