Repository navigation
Conversation
kojiws
force-pushed
the
add-pkcs12-docs-ja
branch
from
September 11, 2026 14:27
13e468e to
e0fd41c
Compare
kojiws
force-pushed
the
add-pkcs12-docs-ja
branch
from
October 13, 2026 04:41
e0fd41c to
979b5ee
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The translation, links, examples, and navigation changes consistently match the established English documentation.
0 open findings
What changed in this PR
Adds Japanese PKCS #12 documentation, aligned with the existing English manual and dependent Japanese Doxygen content.
Changes:
- Documents PKCS #12 usage, ownership, serialization, and compatibility APIs.
- Adds PFX to supported formats.
- Adds PKCS #12 API pages to Japanese navigation.
| File | Description |
|---|---|
wolfSSL/src-ja/chapter04.md |
Adds the translated PKCS #12 guide. |
wolfSSL/src-ja/chapter07.md |
Documents PFX support. |
wolfSSL/mkdocs-ja.yml |
Adds PKCS #12 reference pages. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yosuke-wolfssl
left a comment
yosuke-wolfssl
left a comment
There was a problem hiding this comment.
I'll send my review to the author directly.
kojiws
force-pushed
the
add-pkcs12-docs-ja
branch
from
October 13, 2026 08:43
3b3d29b to
3892208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Japanese translation of the PKCS#12 manual content added in #281:
src-ja/chapter04.md— the PKCS#12 section under PKCS Supportsrc-ja/chapter07.md— PFX added to Supported Formats and Sizesmkdocs-ja.yml—group__PKCS12.mdandpkcs12_8h.mdin the Japanese navOne intentional difference from the English text: it links
HAVE_PKCS12tochapter02.md#have_pkcs12, but Japanese chapter 2 has no such heading, so themacro is plain code here rather than a dead link.
Depends on wolfSSL/wolfssl#11437 (Japanese Doxygen comments) — merge that first.
Testing
make DOC_LANG=JA pdfandmake DOC_LANG=JA htmlboth build clean.All ten functions render, every added cross-link resolves, and the Japanese text
appears correctly in the PDF.