Repository navigation
Fix calling usermod overlay prior to setup - #5933
Open
willmmiles wants to merge 2 commits into
Open
willmmiles wants to merge 2 commits into
willmmiles wants to merge 2 commits into
Conversation
This function is unused - no need to pay for the indirection.
If not using a relay, explicitly black out the LED data instead of calling the rendering engine at boot. This avoids calling usermod overlays prior to usermod setup.
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Remove the show callback wled00/FX.h, wled00/FX_fcn.cpp |
WS2812FX no longer declares or stores a show callback. WS2812FX::show() calls handleOverlayDraw() to draw overlays. |
Clear buses during strip initialization wled00/bus_manager.h, wled00/bus_manager.cpp, wled00/wled.cpp |
BusManager::blank() sets every pixel on each bus to black. When no relay pin is configured, beginStrip() blanks and shows through BusManager. It resets doInitBusses after strip initialization. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: dedehai, softhack007
Merge Risk: 
83c0b
-
The changed boot path blanks the LEDs without invoking overlays before setup. No issue identified here requires a fix before merging.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately describes the primary change: preventing usermod overlays from running before setup during strip initialization. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
softhack007
reviewed
Oct 24, 2026
Member
|
This is the right fix 👍 much better than adding quirks into usermods that need to draw as an overlay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes:
beginStrip()instead of callingshow(). This avoids triggering usermods and running the whole effect engine to produce what we want to be a deterministic output. It's also faster.setShowCallback(). I believe this was meant to enable usermod overlays, at the right point in the boot sequence, but was used incorrectly. It's also no longer necessary to pay the performance penalty for doing the check and making the indirect function call.Ref: #5920 (comment)
Summary by CodeRabbit