Repository navigation
fix: depend on rechoir v0.8 again for Node.js 20 support - #4890
alexander-akait wants to merge 1 commit into
Conversation
rechoir 1.0 requires Node.js >= 22.15.0, while webpack-cli supports >= 20.9.0, so installs with Yarn 1 or engine-strict fail on Node.js 20. This reverts #4881 and ignores rechoir 1.x in Dependabot. Claude-Session: https://claude.ai/code/session_013FhutRFjuQemBzekJMYcqL
🦋 Changeset detectedLatest commit: 6c2175b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This PR is packaged and the instant preview is available (6c2175b). Install it locally:
npm i -D webpack-cli@https://pkg.pr.new/webpack-cli@6c2175b
yarn add -D webpack-cli@https://pkg.pr.new/webpack-cli@6c2175b
pnpm add -D webpack-cli@https://pkg.pr.new/webpack-cli@6c2175b |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4890 +/- ##
==========================================
- Coverage 95.08% 91.55% -3.53%
==========================================
Files 14 14
Lines 5874 5874
Branches 894 852 -42
==========================================
- Hits 5585 5378 -207
- Misses 288 491 +203
- Partials 1 5 +4 see 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
webpack-cli@7.3.0depends onrechoir@^1.0.0.rechoir1.0 requires Node.js>= 22.15.0, butwebpack-clisupports>=20.9.0. On Node.js 20, installingwebpack-cliwith Yarn 1, or with npm'sengine-strict, fails:#4875 had moved back to
rechoir0.8 for this reason, but Dependabot bumped it to 1.0 again in #4881, and 7.3.0 shipped with it.Changes
rechoiris^0.8.0again. The lockfile change only touchesrechoir; the code already works with 0.8.ignorerule forrechoir>=1.0.0, with a TODO to remove it oncewebpack-clirequires Node.js 22.15.CI note
create-webpack-app's "uses yarn as the package manager" test fails on Node.js 20 on every PR right now (for example #4889). It installs the publishedwebpack-cli@7.3.0, so it will keep failing, on this PR too, until a release with this fix is published.Locally,
npm ciinstallsrechoir@0.8.0from the updated lockfile, and the config-format and config-lookup tests pass (21 suites).Generated by Claude Code
Summary by CodeRabbit