Repository navigation
Give samplingMode precedence over legacy topK and temperature - #225
Merged
michaelwasserman merged 1 commit intoOct 16, 2026
Merged
michaelwasserman merged 1 commit into
michaelwasserman merged 1 commit into
Conversation
Update the spec algorithms and explainer so that when both samplingMode and legacy raw sampling parameters (topK or temperature) are provided, samplingMode takes precedence instead of throwing a TypeError. Also update the IDL deprecation comments on params(), topK, temperature, and LanguageModelParams to point to samplingMode.
michaelwasserman
approved these changes
Oct 16, 2026
github-actions Bot
added a commit
that referenced
this pull request
Oct 16, 2026
SHA: 6dac677 Reason: push, by michaelwasserman Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the spec algorithms and explainer so that when both
samplingModeand legacy raw sampling parameters (topKortemperature) are provided,samplingModetakes precedence instead of throwing aTypeError. Also updates the IDL deprecation comments onparams(),topK,temperature, andLanguageModelParamsto point tosamplingMode.Matches the Chromium implementation in https://crrev.com/c/8591422.
Preview | Diff