Repository navigation
fix(tooling): adding a new workflow to uprade the SDK version every W… - #754
Kesari3008 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18409ec19f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| yarn workspace @webex/cc-store test:unit | ||
| yarn workspace @webex/cc-store build | ||
| yarn workspace samples-cc-react-app build |
There was a problem hiding this comment.
On every fresh scheduled runner, this block runs the store test before any topological workspace build. test:unit type-checks imports from @webex/test-fixtures, and both that package and the sample's @webex/cc-* imports point at untracked dist/type outputs, so yarn install alone leaves the first tsc with unresolved modules and the create-PR step is never reached. Run yarn build:dev (or equivalent topological builds) before these checks.
AGENTS.md reference: AGENTS.md:L84-L85
Useful? React with 👍 / 👎.
| run: | | ||
| version="$(npm view @webex/contact-center@next version)" | ||
| echo "version=$version" >> "$GITHUB_OUTPUT" | ||
| yarn workspace @webex/cc-store add "@webex/contact-center@$version" |
There was a problem hiding this comment.
Whenever the next tag advances, this command changes the store manifest and lockfile, but the generated branch never updates the exact SDK versions recorded in packages/contact-center/store/ai-docs/store-spec.md:51,97,473 or ai-docs/CONTRACTS.md:29. Every automated PR therefore immediately leaves the repository's contract/spec documentation claiming the old SDK; update those claims as part of the automation (or remove the version snapshots).
AGENTS.md reference: AGENTS.md:L68-L68
Useful? React with 👍 / 👎.
| version="$(npm view @webex/contact-center@next version)" | ||
| echo "version=$version" >> "$GITHUB_OUTPUT" | ||
| yarn workspace @webex/cc-store add "@webex/contact-center@$version" | ||
| yarn workspace samples-cc-react-app add "@webex/contact-center@$version" |
There was a problem hiding this comment.
Whenever the fetched version differs from 3.12.0-next.159, this advances the sample's direct dependency while leaving its exact webex@3.12.0-next.249 dependency unchanged; that umbrella package's lockfile manifest itself pins @webex/contact-center@3.12.0-next.159. The generated lockfile therefore installs two contact-center versions, contrary to the single-copy alignment documented in store-spec.md:473-476, so the corresponding umbrella release should be resolved and updated (or the update deferred until it embeds the selected contact-center build).
Useful? React with 👍 / 👎.
| - name: Create pull request | ||
| uses: peter-evans/create-pull-request@v7 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
For a PR opened with the repository GITHUB_TOKEN, GitHub suppresses workflow events generated by that token. The full CI in .github/workflows/pull-request.yml:4-7 listens only for pull_request_target opened/labeled/reopened events, so neither this PR creation nor its labels starts the lint and full unit-test jobs, leaving the dependency PR with only this workflow's partial validation. Use a GitHub App or PAT token that is allowed to trigger the PR workflow.
Useful? React with 👍 / 👎.
COMPLETES #AD-HOC
This pull request addresses
Update SDK version weekly
by making the following changes
Add a new yl worflow to run in github actions weekly to update SDK version
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.