Skip to content

fix: require Node.js 22.23.4, 24.22.1 or 26.12.1 for the eMudhra intermediate CA compromise - #1366

Merged
plum117 merged 1 commit into
webdriverio:mainfrom
plum117:chore/node-floor-security
Oct 24, 2026
Merged

plum117 merged 1 commit into
webdriverio:mainfrom
plum117:chore/node-floor-security

Conversation

@plum117

@plum117 plum117 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Closes #1365. Same floor as WebdriverIO v10 (webdriverio/webdriverio#16211) and expect-webdriverio (webdriverio/expect-webdriverio#2405).

  • engines.node of the 5 packages → >=22.23.4 <23 || >=24.22.1 <25 || >=26.12.1: first releases with the updated CA store for the eMudhra intermediate CA compromise. minor changeset: Yarn 1 and engine-strict installs stop on older versions.
  • .agents/setup and .agents/resume read the || range. Before, they stripped >= and compared one version.
  • check-latest: true on the 16 .nvmrc setup steps: v24 can resolve to an older runner cache (24.21.0 on Ubuntu and macOS in webdriverio CI).
  • README and docs/v11-migration.md.

How you tested

pnpm install --frozen-lockfile && pnpm build && pnpm test on Node 22.23.4: exit 0 (oxlint, tsc, 1196 unit tests), no engine warning.

.agents/resume with the new engines, main script vs this PR:

Node.js main PR
22.22.3 refused refused
22.23.4 accepted accepted
24.20.0 accepted refused
24.22.1 accepted accepted
26.11.1 accepted refused

@changeset-bot

changeset-bot Bot commented Oct 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 498cbe8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@wdio/image-comparison-core Minor
@wdio/ocr-service Minor
@wdio/visual-reporter Minor
@wdio/visual-service Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@plum117
plum117 marked this pull request as ready for review October 24, 2026 10:08
@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Raises the Node.js requirement across the root project and all four published packages.

  • Visual-testing packages now require Node.js releases with the updated CA store.
  • Agent setup checks each supported Node.js version range.
  • CI jobs look up the latest Node.js release in the .nvmrc line.

No actionable issues were found. This review checked source and configuration; it did not run builds or tests.

Reviews (1) · Last reviewed commit: "fix: require Node.js 22.23.4, 24.22.1 or..." · Reviewed by Greptile

@plum117
plum117 merged commit daa60df into webdriverio:main Oct 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require the Node.js releases with the eMudhra CA fix (22.23.4, 24.22.1, 26.12.1)

1 participant