Repository navigation
Conversation
baylesj
force-pushed
the
baylesj/issue-343-quic-scrub
branch
from
October 29, 2026 21:35
a9c7d48 to
58dc588
Compare
baylesj
changed the title
baylesj
marked this pull request as ready for review
October 29, 2026 21:39
baylesj
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #343 (part of #341). Builds on #378, so this PR targets that branch and the diff only shows the changes on top of it.
#378 defines OSP messages, OSP message streams, and OSP connections, and uses them for agent status and message delivery. A few places still talk about QUIC streams and connections: the video, data, and feedback frame sections, the note on request and watch IDs, protocol extensions, and Appendix A.
This PR rewrites those places to use the terms from #378. It also adds the QUIC keep-alive details that #378 removed from the application spec to the network spec: send
agent-status-requestmessages more often than the idle_timeout (25 seconds recommended), don't use PING frames, and close with error code 5139. It also fixes the feedback section, which said "video frames" by mistake.