Repository navigation
Conversation
The fspy file-access tracking family (fspy, fspy_nostd, fspy_shared, fspy_shm, ...) only builds on Windows, macOS, and Linux, so any other platform could not build Vite+ at all: its always-on dependency chain (vt -> vt_server -> vt_client -> vt_ipc_shared -> fspy_ipc_str) pulled in fspy_nostd, which has no backend outside those three OSes. Instead of porting fspy_nostd or adding no-op backends and per-item cfgs, gate the fspy crates at the crate level and keep the IPC layer portable: - fspy_ipc_str no longer depends on fspy_nostd/fspy_nostd_alloc. The two C-string interop methods (from_os_c_str, to_os_c_string_in) move into fspy_shared as free functions built on fspy_shared's own types, so IpcStr stays a cross-platform wire type while fspy_nostd leaves the always-on graph entirely. - vt's fspy-only execution code (FspyTracking, the TrackingIncomplete reason, is_ignored, the tracking_incomplete summary field) is now excluded via the existing cfg(fspy) when tracking is not compiled in. - On such platforms a task requesting automatic input/output inference reports that tracking is unsupported and must configure input and output manually to be cached (FspyUnsupported), as intended. Verified on FreeBSD 15: cargo check/clippy/test pass for the product graph (vt_bin, vt, vt_client, vt_server, vt_ipc_shared, fspy_ipc_str) and the vp binary builds and runs. Co-authored-by: Hermes Agent <noreply@nousresearch.com>
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fspy file-access tracking family (fspy, fspy_nostd, fspy_shared, fspy_shm, ...) only builds on Windows, macOS, and Linux, so any other platform could not build Vite+ at all: its always-on dependency chain (vt -> vt_server -> vt_client -> vt_ipc_shared -> fspy_ipc_str) pulled in fspy_nostd, which has no backend outside those three OSes.
Instead of porting fspy_nostd or adding no-op backends and per-item cfgs, gate the fspy crates at the crate level and keep the IPC layer portable:
Verified on FreeBSD 15: cargo check/clippy/test pass for the product graph (vt_bin, vt, vt_client, vt_server, vt_ipc_shared, fspy_ipc_str) and the vp binary builds and runs.