Skip to content

Fixing #2938 - #2942

Merged
DavyLandman merged 3 commits into
mainfrom
fix/issue2938
Oct 21, 2026
Merged

DavyLandman merged 3 commits into
mainfrom
fix/issue2938

Conversation

@jurgenvinju

@jurgenvinju jurgenvinju commented Oct 20, 2026 •

Copy link
Copy Markdown
Member
  • add failing test
  • fix issue by preventing overlapping name generation for regulars that are the same but have different conditionals.

@jurgenvinju jurgenvinju self-assigned this Oct 20, 2026
Instead of making all regular symbols with different conditions the
same, as planned, we made all names for symbols with different
conditions different. The reason is that these variables are being
used from different contexts, exactly where they need to remain
different.
@jurgenvinju
jurgenvinju marked this pull request as ready for review October 20, 2026 17:55
@sonarqubecloud

Copy link
Copy Markdown

@jurgenvinju

Copy link
Copy Markdown
Member Author

Some people are waiting for this fix to be released; so perhaps we can prioritize this one.

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45%. Comparing base (9115006) to head (ab2e54a).

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2942   +/-   ##
=======================================
  Coverage       45%     45%           
- Complexity    6807    6812    +5     
=======================================
  Files          844     844           
  Lines        68823   68823           
  Branches     10038   10038           
=======================================
+ Hits         31415   31425   +10     
  Misses       35005   35005           
+ Partials      2403    2393   -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman
DavyLandman merged commit d81f43c into main Oct 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants