Skip to content

🧲 Add TF superconductor critical state plotting - #4732

Draft
chris-ashe wants to merge 1 commit into
mainfrom
add_tf_supercon_crit_graphs
Draft

chris-ashe wants to merge 1 commit into
mainfrom
add_tf_supercon_crit_graphs

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added TF Coil Toroidal field coil Plotting labels Nov 6, 2026
@chris-ashe chris-ashe changed the title Add TF superconductor critical state plotting and model dispatch func… 🧲 Add TF superconductor critical state plotting Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

⚠️ improve_quality_job warning!

Files changed by this PR have introduced 2 more linting errors when compared to main

Please fix these

To check what these are, run hatch run lint:fmt_extra on your branch and on main

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.00000% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.24%. Comparing base (030521f) to head (41f2f99).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ess/core/io/plot/summary/magnets/superconductor.py 12.90% 81 Missing ⚠️
process/models/superconductors.py 73.33% 8 Missing ⚠️
process/core/io/plot/summary/api.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4732      +/-   ##
==========================================
- Coverage   50.27%   50.24%   -0.04%     
==========================================
  Files         181      182       +1     
  Lines       30645    30791     +146     
==========================================
+ Hits        15407    15470      +63     
- Misses      15238    15321      +83     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Plotting TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants