Repository navigation
Conversation
transbot
marked this pull request as ready for review
November 11, 2026 00:12
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
按维护者批准关闭。当前 Roslyn 4.8.0 已满足教材构建及预期编译诊断,现有安全告警通过 #67、#68 定向修补完成,本次不采用 4.13.0 升级。
问题与修复
#47与#48单独升级时,Microsoft.CodeAnalysis.Common的精确版本要求分别为4.8.0与4.13.0,导致NU1107。本PR同时将Microsoft.CodeAnalysis及Microsoft.CodeAnalysis.CSharp.Scripting升级为4.13.0,统一审阅;原两个PR保持打开,不建议分别合并。
只修改Directory.Packages.props的两个版本,保留net6.0/net7.0/net8.0、所有测试方法与断言、中文版已修正源码及教材故意错误示例。未覆盖传递版本、忽略诊断、过滤或跳过测试。实际还原的Common/CSharp等核心Roslyn包均为4.13.0。
最新提交验收完成
远端HEAD
6305e966a00cc91c70c44d2e0a00826ad41496bc。三平台、两种区域设置、代码分析六项全部实际通过;差异和对应分析报告已审阅。暂不合并,供人工审查。9239846a49ad24a8259d88b87a6ca9ae7f451fd1ecbdc1836bbb6286adff5554已核验并审阅。保留的失败与重跑证据
首次葡萄牙语任务130214437387完整执行69程序集/1936次,其中清单5.34/5.35的外部下载测试在三个框架下各100秒超时,6次失败;日志是TaskCanceledException,而非Roslyn还原或编译冲突。任务自然结束,未执行取消。
同一HEAD完整重跑130221941782,69程序集/1936次全部通过;其他任务沿用同一HEAD的已实际执行成功结果。未修改代码、超时或测试要求,保留外部网站依赖的不稳定记录。
#49的MSTest配套及既有测试类发现修复单独审查;本PR未包含它,故本PR仍为1936次,#49为1945次。区域设置策略建议另行审议,本次保持既定矩阵。