Repository navigation
docs: replace the release checklist with the pointer to the Tracker process #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,20 +2,14 @@ | |
|
|
||
| This repository holds a single publishable crate, `torrust-server-lib`. | ||
|
|
||
| The process is the one defined for workspace packages in the Torrust Tracker, which is the source | ||
| of truth. Follow its | ||
| [Publishing a Workspace Package](https://github.com/torrust/torrust-tracker/blob/develop/docs/release_process.md#publishing-a-workspace-package) | ||
| section (versioning, changelog, dry run, publish, signed tag). Do not copy it here. | ||
| Releases follow the process defined for workspace packages in the Torrust Tracker, which is the | ||
| source of truth: | ||
| [Releasing Workspace Packages](https://github.com/torrust/torrust-tracker/blob/develop/docs/release-process/workspace-packages.md). | ||
| Do not copy its steps here. | ||
|
|
||
| ## Differences in this repository | ||
|
|
||
| - There is no `develop` branch: releases are cut from `main`. | ||
| - There is no `deployment-packages.yaml` workflow and no `releases/pkg/**` branches, so the | ||
| **manual fallback** of the Tracker document is the only path. | ||
| "Standalone-Repository Crate" section of the Tracker document is the only path (manual publish). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Nit][F1] Link the section rather than only quoting its name. The target has |
||
| - The tag is `v<semver>` (for example `v0.6.0`), not `pkg/<crate-name>/v<semver>`. | ||
|
|
||
| ## Checklist | ||
|
|
||
| 1. Merge a PR that bumps `version` in `Cargo.toml` and adds the `CHANGELOG.md` entry. | ||
| 2. From the merged `main`: `cargo publish --dry-run`, then `cargo publish`. | ||
| 3. Create the signed tag on the published commit and push it to `torrust/torrust-server-lib`. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion][F2] The target's dependent-manifest step has no counterpart here.
Precondition 2 of the linked document (both variants) asks to raise the crate's requirement "in every manifest that depends on it" in the same PR, keeping each
path. This crate's dependents live in the tracker and take it from crates.io: atdevelopthe rootCargo.toml(line 114) and four packages pin0.6.0. For this crate the step is a tracker PR opened after the publish, since a requirement on an unpublished version does not resolve. A fourth difference saying so (or the same line in the target's standalone section, for every standalone crate) would close the loop; this carries the earlier F6.