Skip to content

audio: dax: check param header fits before reading it #11342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shrusti-pk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: dax: check param header fits before reading it #11342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/audio/module_adapter/module/dolby/dax.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,12 @@ static int update_params_from_buffer(struct processing_module *mod, void *data,
uint32_t param_data_size;

for (uint32_t i = 0; i < data_size;) {
/* Need a whole param header in the remaining bytes to read id/size */
if (data_size - i < param_header_size) {
comp_err(dev, "param header truncated, pos %u, size %u", i, data_size);
return -EINVAL;
}

param = (struct module_param *)(pos);
if (param->size < param_header_size ||
param->size > data_size - i ||
Expand Down
Loading