Repository navigation
Conversation
bardliao
requested review from
kv2019i and
ujfalusi
and
a balanced review from Copilot
October 23, 2026 02:11
bardliao
requested review from
dbaluta,
lgirdwood,
plbossart and
ranj063
as code owners
October 23, 2026 02:11
There was a problem hiding this comment.
🟡 Changes recommended
A zero mask aborts loading before custom feature topologies can load, preventing the intended custom-only configuration.
What changed in this PR
This PR adds configurable function-topology selection to Intel SOF, aiming to let custom topologies supplied through feature_topologies replace standard pipelines.
Changes:
- Adds a read-only
function_tplg_maskmodule parameter, defaulting to all devices. - Applies the mask to SoundWire and I2S topology discovery with best-effort loading.
- Returns an error when an explicit mask yields no function topologies.
| File | Description |
|---|---|
| sound/soc/intel/common/sof-function-topology-lib.c | Adds mask-based function-topology selection and empty-selection checks. |
Review effort: Balanced
…on topology loading Allow users to skip loading specific function topologies when the BE links are problematic or not required. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
While we can load feature topologies to add features to the generial function topology, we can not change the modules in the function topology. This commit allow selecting function topology variants through the feature_variant module parameter to use the variant function topology instead of the generic function topology. Fall back to the generic topology when a configured variant is unavailable. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
mask_function_topology
branch
from
October 23, 2026 09:13
5878b6d to
01cbec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function topology provides a standard pipeline. Although feature topologies allow appending widgets, they do not support modifying or inserting widgets into the middle of the pipeline. To achieve this, users must deploy a customized topology.
Add support to bypass loading function topologies so that custom topologies can be loaded directly through the 'feature_topologies' module parameter.