Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 14, 2026 22:57
Wkhanex
reviewed
Oct 16, 2026
Wkhanex
left a comment
There was a problem hiding this comment.
AI-assisted POSIX validation at 5632cdc51a81 using Python 3.12.14 and IPython 9.17.1: I invoked the real magic against files whose paths contain spaces, an internal apostrophe, a literal backslash, and literal outer apostrophes. I also checked -- "-o.env" so an option-like filename reaches path resolution without being treated as a flag. All seven calls loaded the expected value.
The literal-backslash case is a useful regression guard for this approach: removing only the matching outer quotes preserves the filename rather than applying an additional shell-style unescape pass. I did not execute native Windows behavior; that remains outside these checks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IPython's POSIX argument parser preserves the quote characters used to group a filename. As a result,
%dotenv "my project/app.env"reportscannot find .env fileeven when the file exists.On non-Windows platforms, remove a matching pair of outer single or double quotes before looking up the file. This also lets quoted absolute and
~/paths reach the existing path-resolution behavior. Backslashes and internal apostrophes are preserved. Windows keeps its existing native argument parsing, including literal apostrophes in filenames.Tests
-o. Native Windows still exercises double quotes; unsupported single-quote grouping is expected to raise UsageError without changing the environment.git diff --checkall passed.AI assistance: prepared and tested with OpenAI Codex, including independent automated review. No human review or hosted CI pass is claimed.