Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SanitizeLabelValue in prometheus_exporter.cc escapes backslash and double quote but not line feed, which the Prometheus text exposition format also requires to be written as \n inside a label value. The REST dispatcher percent-decodes the model name from the request path and records it as the model_name label of /tensorflow/serving/request_count for every request, including ones for models that do not exist, so an unauthenticated POST /v1/models/x%0Ay:predict leaves a metric cell whose label value contains a raw line feed. From then on GeneratePage emits that sample split across two lines and line-based scrapers reject the page: the Python prometheus_client parser fails with Invalid value: '{model_name="x', and the OpenMetrics lexer refuses a raw newline inside a quoted label value. The cell is never removed, so the metrics endpoint stays unparseable until the server restarts.
Escaping the line feed in SanitizeLabelValue, next to the two existing escapes, keeps each sample on one line and the label value round-trips as x\ny on the scraper side. A test next to the existing SanitizeLabelValue test checks the escaped output.