Repository navigation
Allow specifying the protoc path in protogen - #323
Merged
Merged
Conversation
|
|
stephanos
marked this pull request as ready for review
October 30, 2026 18:42
chrsmith
approved these changes
Oct 30, 2026
chrsmith
left a comment
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I think this is good enough as-is. But my understanding is that when dealing with $PATH and "security issues", there's all sorts of weird edge cases to consider.
MAAAAAAyyyyybee we want to say "fully-qualified path to protoc"? Maaaaayyyybbeee we want to add a check that the file actually exists? (And if not, fail? And have if protocoPathFlag == "" { protocoPathFlag = lookupFromPATH() }?
But as far as this change is concerned, in the context of:
- It just works like before, using PATH
- Allows you to specify a fully-qualified path to pin a specific version
This checks all the boxes 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add
--protoc-pathto protogen, defaulting toprotoc.Why?
Let callers pass a pinned protoc executable without modifying PATH.