Repository navigation
fix(release): publish patches from git tags - #3338
pratap0007 wants to merge 1 commit into
Conversation
Stop patch releases from committing VERSION and pushing the protected release-vX.Y.x branch. Tag the branch tip, push release-vX.Y.Z, and choose the next patch from the highest existing tag so an unmerged tag is not reused. make still injects clientVersion from ldflags. Signed-off-by: pratap0007 <shverma@redhat.com> Assisted-by: Grok 4.7 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
tekton-robot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/M
|
/retest |
There was a problem hiding this comment.
🟡 Changes recommended
Legacy VERSION files still override detected tags, causing Make builds to embed outdated client versions.
1 open finding
What changed in this PR
Moves patch releases toward tag-based versioning without updating protected maintenance branches.
Changes:
- Stops committing VERSION during releases.
- Adds git-derived version fallback for Make builds.
- Selects patch numbers from the highest existing tag and pushes version-specific branches.
| File | Description |
|---|---|
tekton/release.sh |
Removes VERSION updates and release commits. |
Makefile |
Adds git-tag fallback for client version injection. |
.github/workflows/patch-release.yaml |
Updates patch numbering and tag/branch publication. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| VERSIONLDFLAG := -X github.com/tektoncd/cli/pkg/cmd/version.clientVersion=$(shell cat VERSION) | ||
| else ifneq ($(GIT_VERSION),) | ||
| VERSIONLDFLAG := -X github.com/tektoncd/cli/pkg/cmd/version.clientVersion=$(GIT_VERSION) |
Stop patch releases from committing VERSION and pushing the protected release-vX.Y.x branch. Tag the branch tip, push release-vX.Y.Z, and choose the next patch from the highest existing tag so an unmerged tag is not reused. make still injects clientVersion from ldflags.
Assisted-by: Grok 4.7 (via Cursor)
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes