Repository navigation
feat(agentrepo): report prose preflight argument blockers - #1068
Open
tbhb-agent wants to merge 1 commit into
Open
tbhb-agent wants to merge 1 commit into
tbhb-agent wants to merge 1 commit into
Conversation
Before any probe, the fix-prose preflight reports whether a run can start at all. Moving it into agentrepo starts with the three early BLOCKED reports: a directory outside Git, a missing target argument and a target that isn't a regular file. Each keeps the shell's report, streams and exit status, including the root-relative target display. Tests compare the Go output with the unchanged script where bash is available. A target that exists stops with a refusal for now, because scope probing and lint execution belong to later work. Nothing else changes: the shell script and its callers remain, which keeps this within the N-2 compatibility policy. Fixes #1029 Assisted-by: claude:claude-sonnet-5-5 Signed-off-by: Tony Burns <tony@tonyburns.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
agentrepo prose preflight, which reports the early BLOCKED cases of the fix-prose preflight. The cases are a directory outside Git, a missing target argument and a target that isn't a regular file. Each keeps the shell script's report, streams and exit status, including the root-relative target display. A target that exists stops with a refusal for now.Why
Moving the fix-prose preflight into Go starts with the cases that run before any probe. Scope probing and lint execution belong to later children of the prose migration. The shell script and its callers remain, which keeps the change within the N-2 compatibility policy.
Verification
go test ./internal/agentrepo -run '^TestProse' -count=1passed.Risk
The new subcommand is additive and nothing calls it yet. Revert the commit to back it out. No gate, allow list, or policy changes.
Related
Fixes #1029
Part of #327