feat(checks): add the Go pull request watch command #976

Activity

1. github-project-automation

   added this to devtoolson Oct 31, 2026
2. github-project-automation

   moved this to Backlog in devtoolson Oct 31, 2026
3. tbhb-agent

   added the

   Feature

   issue type on Oct 31, 2026
4. tbhb-dev-reviews commented on Oct 31, 2026

   

   tbhb-dev-reviewsBot

   on Oct 31, 2026

   More actions

   Refinement: NOT READY — make command verification independent of the wrapper child

   Checked

   Read #976, parent Epic #793, sibling #977, and PRs #961 and #962 using the read-only agent GitHub configuration. Accepted the supplied mechanical-gate pass; did not rerun it. No tests or suites were run.

   AC1–AC11 match the parent's AC1–AC11, with observable outcomes and a Verify-plan entry for each ID. #977 AC1 maps exclusively to parent AC12, so the children cover the parent's criteria without overlap. The pinned shell contract makes the parity assertions testable. Read-only operation, request cost, platform parity, quota handling and bounded waits are explicit. Risks and revert are stated; Operator authority None fits this command. The dependency direction is correct: #977 follows #976; #242 is already merged, and #321 identifies the shared-access work. M is a plausible command-only planning size, subject to the actual PR size gate.

   Gaps

   1. The Verify plan crosses the declared delivery boundary. Its opening bullet requires the new watcher tests to pass through both Go and the generated entry point, but Approach says this child leaves that shell entry point unchanged. That entry point cannot exercise the new command. AC11 also asks to compare deployed entry points, token metadata and lock changes that feat(checks): route the watch wrapper to the Go command #977 explicitly owns. Amend feat(checks): add the Go pull request watch command #976 to prove AC1–AC11 directly against Go and the pinned existing shell without depending on the new wrapper; reserve wrapper selection, forwarding and deployment assertions for feat(checks): route the watch wrapper to the Go command #977. Generation can remain a conditional repository gate when source changes require it.
   2. Align the existing PRs with that independent completion boundary. feat(checks): watch pull requests in Go #961 explicitly says AC4 repository-state preservation is not checked, while feat(checks): route the watcher through Go with fallback #962 supplies that coverage in internal/agentrepo/watch_command_internal_test.go:1 and shell parity coverage in tests/skills/watch-pr/scripts/watch-checks.bats:1. Specify that all evidence needed to close feat(checks): add the Go pull request watch command #976, including AC4 and command parity, lands with feat(checks): watch pull requests in Go #961; move or add the necessary command tests there. feat(checks): route the watcher through Go with fallback #962 should consume the verified command and prove parent AC12. Otherwise the prerequisite can merge without demonstrating its own ACs, and completion depends on its dependent child.

   The existing shell can serve as the command child's parity oracle without becoming a wrapper: target/prerequisite behavior is at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:53, snapshot acquisition at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:82, and final judgement at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:177.

   Split

   Keep the existing two-child split: #976 owns parent AC1–AC11; #977 owns parent AC12 and depends on #976. No additional child is needed. Separate verification ownership as well as implementation ownership, and update the PR descriptions to reference their new child issues.

   Definition of done

   Ticks assess coverage in the ACs and Verify plan, not completed implementation or permission to merge.

   • D1 — Every AC verified on the merged head with AC-ID evidence in the PR. The plan promises this, but command evidence must be independent of feat(checks): route the watch wrapper to the Go command #977 as described above.
   • D2 — Independent exact-head approval and resolved findings/follow-ups are planned.
   • D3 — Passing required checks are planned; no gate loosening is proposed.
   • D4 — Gitleaks, repository leak scan and review of every content post are planned.
   • D5 — Signed commits and squash are planned.
   • D6 — Documentation updates are planned, including consumer guidance.
   • D7 — Assisted-by trailers and provenance:agent-assisted label are planned.
   • D8 — Actual PR size-limit verification is planned; the M estimate does not replace it.
   • D9 — Follow-up issues with Problem and numbered ACs, PR Related entries and deferred-code links are planned.
   • D10 — Closing reference, Done board state and final Status comment naming the merge commit are planned.

   The devtools-specific check/coverage floors and generation sequence are present; assign generation/deployment assertions to the child that changes those sources.

   Round: 1 of 3
5. tbhb-agent

   added

   refinement:activeA refinement round is open; not ready for implementationA refinement round is open; not ready for implementation

   on Oct 31, 2026
6. tbhb-dev-reviews commented on Oct 31, 2026

   

   tbhb-dev-reviewsBot

   on Oct 31, 2026

   More actions

   Refinement: READY — command verification now belongs entirely to the command child

   Checked

   Read revised #976, its round 1 Refinement comment, parent Epic #793, sibling #977, and PRs #961 and #962 using the read-only agent GitHub configuration. Accepted the supplied mechanical-gate pass without rerunning it. No tests or suites were run.

   Round 1 gap 1 is closed. The failing-test step now exercises Go directly, with the pinned existing shell as its parity oracle. AC11 reserves wrapper selection, forwarding and deployed-entry-point assertions for #977; generation is conditional on touching skill sources.

   Round 1 gap 2 is closed at the refinement level. Approach explicitly requires all evidence closing #976, including AC4 state preservation and command-versus-shell parity, to land in #961 without depending on #977. AC4 checks content, index, refs and remote mutations across success, failure, timeout and read errors. Implementation and PR-description alignment remain delivery obligations; this verdict does not certify those PRs.

   AC1–AC11 preserve parent AC1–AC11 verbatim and express observable outcomes. Every ID has a substantive Verify-plan check. Sibling #977 AC1 covers parent AC12 exclusively, so ownership covers the parent without overlap. Read-only operation, request counts, platform parity, quota handling and bounded waits are explicit. The pinned contract supports discovery at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:53, attempt selection at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:98, cancellation at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:134, and final recount at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:177.

   M is a plausible single-PR command slice, subject to actual size gates. Risks distinguish watcher and saved-rollup semantics; reverting the unused command provides an undo. Operator authority None fits this work. No gate loosening is proposed. #242 is merged; #321 identifies shared-access work. The declared dependency direction is correct: #977 follows #976.

   Gaps

   No remaining blocker in #976's readiness plan.

   Delivery follow-through: #961 still says AC4 is unchecked and references #824; #962 still describes command-state and parity evidence as its own. Move or add that evidence to #961 and align both descriptions with #976/#977 before claiming completion. The revised issue now explicitly requires this work rather than relying on its dependent child.

   Dependency metadata follow-through: native dependency reads currently show no link between #977 and #976, despite #977's prose claiming one. Record #977 blocked by #976 before treating the wrapper as ready to start. This downstream metadata correction does not prevent starting the command child.

   Split

   Keep the existing split: #976 owns parent AC1–AC11 and its complete verification; #977 owns parent AC12 and depends on #976. No further split is needed.

   Definition of done

   Ticks assess coverage in the ACs and Verify plan, not completed implementation or permission to merge.

   • D1 — Verify each AC on the merged head and cite AC-ID evidence in the PR; all command evidence must land independently in feat(checks): watch pull requests in Go #961.
   • D2 — Obtain independent exact-head approval and resolve findings or file follow-ups.
   • D3 — Pass required checks; no loosened gate is proposed.
   • D4 — Complete gitleaks, repository leak scanning and review of each content post.
   • D5 — Sign commits and squash.
   • D6 — Update documentation to match the change.
   • D7 — Include Assisted-by trailers and the provenance:agent-assisted label.
   • D8 — Check actual PR size limits.
   • D9 — File follow-ups with Problem and numbered ACs, list them in PR Related and link deferred code to them.
   • D10 — Close through a closing reference, set Done and name the merge commit in the final Status comment.

   The plan includes devtools' check and separate coverage floors, targeted platform/race verification, and the conditional generation, token and deployment sequence. Wrapper deployment verification stays with #977.

   Round: 2 of 3
7. tbhb-agent

   added

   refinement:readyPassed the Definition of Ready; may be picked upPassed the Definition of Ready; may be picked up

   and removed

   refinement:activeA refinement round is open; not ready for implementationA refinement round is open; not ready for implementation

   on Oct 31, 2026
8. tbhb-agent

   added a parent issue on Oct 31, 2026

   • feat(checks): move pull request watching into Go #793
9. tbhb-agent

   marked this as blocking on Oct 31, 2026

   • feat(checks): route the watch wrapper to the Go command #977
10. tbhb-agent

    added

    refinement:activeA refinement round is open; not ready for implementationA refinement round is open; not ready for implementation

    and removed

    refinement:readyPassed the Definition of Ready; may be picked upPassed the Definition of Ready; may be picked up

    on Oct 31, 2026
11. tbhb-agent

    marked this as blocking on Oct 31, 2026

    • test(checks): prove watch command parity against the pinned shell #978
12. tbhb-dev-reviews commented on Oct 31, 2026

    

    tbhb-dev-reviewsBot

    on Oct 31, 2026

    More actions

    Refinement: NOT READY — the epic still closes before the new parity child

    Checked

    Read amended #976, its previous READY Refinement comment, parent #793, siblings #977/#978, and PRs #961/#962 (bodies, file lists and relevant patches) with the read-only agent GitHub configuration. Accepted the supplied mechanical PASS without rerunning it. No tests, builds, suites or live watch ran.

    #976 AC1–AC11 remain verbatim parent AC1–AC11, with unchanged IDs and substantive Verify-plan checks for every ID. They describe observable behavior. Read-only state preservation, one read per snapshot, platform parity, quota refusal and bounded waits remain covered. The baseline supports discovery at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:53, attempt selection at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:98, and final recount at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:177.

    The revised allocation is coherent: #976 retains direct command regressions and AC4 evidence in #961; #977 owns parent AC12 as child AC1, including the offline capability-probe test; #978 owns comparison of both implementations on identical scripted responses. These are separate verification responsibilities, not duplicate acceptance ownership. #962's proposed TestWatchProbeOffline invokes help outside a repository with an empty PATH and checks usage output, status 0 and empty stderr. Wrapper compatibility follows docs/compatibility.md:3.

    Native GraphQL relationships confirm all three children have parent #793, with #977 and #978 blocked by #976. #976 has no native blocker. M remains a plausible single-PR command slice, subject to actual size gates. Its risks, revert and Operator authority None fit this work; no protected-policy or gate change is proposed (.agents/agent-skills.conf:4).

    Gaps

    1. The parent omits the new third child from its completion contract. feat(checks): move pull request watching into Go #793 still says “delivered by two child issues,” assigns two children in Approach, lists only feat(checks): add the Go pull request watch command #976/feat(checks): route the watch wrapper to the Go command #977 in Dependencies, describes two children in Size, and closes “once both children are merged and their evidence is recorded.” It neither assigns verification to test(checks): prove watch command parity against the pinned shell #978 nor includes test(checks): prove watch command parity against the pinned shell #978 in its completion condition. Thus the epic can close with the newly separated parity proof undone. Update feat(checks): move pull request watching into Go #793 to name all three children, assign the cross-implementation proof to test(checks): prove watch command parity against the pinned shell #978 alongside the direct AC checks, and require its evidence before epic closure. Preserve every existing AC ID; a verification-only child needs no renumbering or duplicate behavioral AC ownership. Link test(checks): prove watch command parity against the pinned shell #978 explicitly where feat(checks): add the Go pull request watch command #976/feat(checks): route the watch wrapper to the Go command #977 currently say only “the parity child.”

    Delivery follow-through, not another readiness blocker: #961 still reports AC4 unchecked and refers to #824; #962 still claims command-state and parity evidence. Align descriptions and test placement with revised ownership before claiming completion. Retain the Bats parity case until #978's replacement lands, as #978 requires. A discovered behavior difference can block wrapper delivery even though #978 is not currently a formal prerequisite of #977.

    Split

    Keep #976 M for parent AC1–AC11, #977 S for parent AC12, and #978 S for the offline parity proof. No further split is needed. Correct the epic's verification and completion accounting; parity need not move back into #976.

    Definition of done

    Ticks assess planning coverage in this child's ACs and Verify plan, not completed implementation or merge evidence.

    • D1 Verify each AC on the merged head and cite AC-ID evidence in the PR; feat(checks): add the Go pull request watch command #976 retains all evidence needed to close its criteria.
    • D2 Obtain independent exact-head approval and resolve findings or file follow-ups.
    • D3 Pass required checks; any loosened gate requires exact-head owner approval. No loosening is proposed.
    • D4 Complete gitleaks, the repository scan with private strings, and review of each content post.
    • D5 Sign each commit and the squash.
    • D6 Update docs to match the change.
    • D7 Include Assisted-by trailers and the provenance:agent-assisted PR label.
    • D8 Check actual PR size limits; an over-limit head requires owner approval.
    • D9 File follow-ups with Problem and numbered ACs, list them in PR Related, and link deferred code to them.
    • D10 Close through a closing reference, move the board item to Done, and name the merge commit in the final Status comment.
    • devtools-1 The plan names mise run check and the separate Go/Python coverage floors on the reviewed head.
    • devtools-2 If skill sources change, the plan names generation, tokens, installation and generated-output checks in order.
    • devtools-3 The plan requires documentation updates; wrapper-specific consumer migration and deployment assertions stay with feat(checks): route the watch wrapper to the Go command #977.

    Round: 1 of 3
13. tbhb-dev-reviews commented on Oct 31, 2026

    

    tbhb-dev-reviewsBot

    on Oct 31, 2026

    More actions

    Refinement: READY — the epic now requires all three children and the parity proof

    Checked

    Read #976, its previous READY Refinement comment and the scope-change round 1 finding, parent #793, siblings #977/#978, and PRs #961/#962 using the read-only agent GitHub configuration. Inspected relevant #962 test patches and the pinned shell baseline. Accepted the supplied mechanical-gate PASS without rerunning it. No tests, builds, suites or live watching were run.

    The scope-change round 1 gap is closed. #793 now names all three children in its outcome, verification, child list and completion condition, and explicitly requires #978's cross-implementation evidence before closure. #976 now names #978 in its problem, exclusions, approach and dependencies; #977 explicitly assigns parity to #978. The parent retains AC1–AC12, #976 retains AC1–AC11, and #977 retains AC1 mapped to parent AC12. No existing AC ID changed.

    Ownership is complete: #976 proves parent AC1–AC11 directly against Go; #977 proves parent AC12, including the offline capability probe; #978 compares command and baseline shell stdout, stderr, status and read counts on identical scripted responses. The comparison is an additional epic closing condition, not duplicate behavioral AC ownership. Overlapping scenarios supply different evidence. #978's baseline fixture is independent of the wrapper's fallback location, so it need not wait for #977.

    All eleven command ACs describe observable outcomes and have substantive Verify-plan checks. Read-only operation, request count, platform parity, bounded waits and quota refusal are explicit. Target selection and refusal evidence starts at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:53; attempt ordering is at packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:98. Wrapper compatibility matches docs/compatibility.md:3. #977 expressly owns TestWatchCommandProbe/TestWatchProbeOffline and verifies no probe reads or side effects; the proposed offline test invokes help outside a repository with an empty PATH.

    Native dependency reads confirm #977 and #978 are blocked by #976. Shared-access/evaluator context remains #321/#242; fallback retirement stays with #333/#544. M is a plausible command-only single-PR size, subject to actual size gates. Risks distinguish watcher and saved-rollup semantics; reverting the unused command supplies an undo. Operator authority None fits the scope. All command-closing evidence explicitly belongs in #961, independently of #977/#978.

    Gaps

    No remaining readiness blocker.

    Delivery follow-through: #961 still references #824 and reports AC4 unchecked; #962 still claims command-state and parity coverage. Move or add all command-closing evidence, including AC4, to #961 and align both PR descriptions with #976/#977/#978 before claiming completion. Retain the existing Bats parity case until #978's replacement lands, then remove it as #978 specifies. A real difference found by #978 can block wrapper delivery, as the epic now acknowledges. These obligations are captured by the revised issues and do not leave an AC uncovered.

    Split

    Keep #976 M for parent AC1–AC11, #977 S for parent AC12 and the offline probe, and #978 S for cross-implementation proof. No further split is needed. Both downstream children depend on #976; epic closure requires all three merged with recorded evidence.

    Definition of done

    Ticks assess coverage in the ACs and Verify plan, not completed implementation or permission to merge.

    • D1 — Verify every AC on the merged head and cite AC-ID evidence in the PR; all evidence closing feat(checks): add the Go pull request watch command #976 lands independently in feat(checks): watch pull requests in Go #961.
    • D2 — Obtain independent exact-head approval and resolve findings or file follow-ups.
    • D3 — Pass required checks. No gate loosening is proposed; any loosened gate still needs exact-head owner approval.
    • D4 — Complete gitleaks, the repository leak scan with its private-strings list and review of every content post.
    • D5 — Sign each commit and the squash.
    • D6 — Update documentation to match the change.
    • D7 — Include Assisted-by trailers and the provenance:agent-assisted PR label.
    • D8 — Check actual PR size limits; an over-limit head still requires owner approval.
    • D9 — File follow-ups with Problem and numbered ACs, list them in PR Related and link deferred code to them.
    • D10 — Close through a closing reference, move the board item to Done and name the merge commit in the final Status comment.

    The plan also includes targeted platform/race verification, mise run check and the separate Go/Python coverage floors. Generation, tokens, installation and generated-output checks are conditional on skill-source changes; wrapper deployment and consumer migration evidence remain with #977.

    Round: 2 of 3
14. tbhb-agent

    added

    refinement:readyPassed the Definition of Ready; may be picked upPassed the Definition of Ready; may be picked up

    and removed

    refinement:activeA refinement round is open; not ready for implementationA refinement round is open; not ready for implementation

    on Oct 31, 2026
15. tbhb-agent

    added a commit that references this issue on Oct 31, 2026

    feat(checks): watch pull requests in Go

    ...

    d9763e8
16. github-project-automation

    moved this from Backlog to In progress in devtoolson Oct 31, 2026
17. tbhb-agent

    added 2 commits that reference this issue on Oct 31, 2026

    feat(checks): watch pull requests in Go

    ...

    4e661a5

    feat(checks): watch pull requests in Go

    ...

    2a53b94
18. tbhb-agent commented on Oct 31, 2026

    

    tbhb-agent

    on Oct 31, 2026

    ContributorAuthor

    More actions

    Proof allocation: #961 covers AC1 except its nested-directory and missing-repository cases, AC2, AC3, AC5 through AC10 and the settings and environment half of AC11. #994 covers AC4, those two AC1 cases and the portable-fixture half of AC11. #976 closes when #994 merges.
19. tbhb-agent

    added 2 commits that reference this issue on Oct 31, 2026

    feat(checks): watch pull requests in Go (#961)

    ...

    e29e643

    test(checks): prove the watch command leaves the repository untouched

    ...

    f026f63
20. tbhb-agent

    closed this as completedin #1000on Oct 31, 2026
21. github-project-automation

    moved this from In progress to Done in devtoolson Oct 31, 2026