Repository navigation
Description
Problem
This issue retires the second allocated group of residual cases in tests/skills/source/lib/: the cases of tests/skills/source/lib/lib.bats from line 260 to its end (709 lines at baseline fd7b680): the review, stamp, reviewer-runner, confirmation, trusted policy, quota, runner deadline, adapter, content-posting and verdict-parity cases. They remain only because they exercised shell behavior that the ports under #321 now replace. The first group (gates.bats, masked-status.bats and lib.bats lines 1 to 259) is the previous child. The group is at most 709 lines at the baseline, below both limits whatever the earlier cleanup removed.
Part of #588 and #321. Deletes test cases only; no shell under packages/agents/source/lib/ changes.
Acceptance criteria
- AC1: Given every case in the allocated group left after the early cleanup, when the extended retirement ledger is read, then each case names the Go test that covers it, or the reason it is dropped, or the reason it needs a real shell, and no case is unaccounted for.
- AC2: Given the merged change, then every case marked deleted is absent, and what remains of
lib.batsis listed with a reason for each case; together with the previous child, the three suites are deleted or reduced to cases that need a real shell. - AC3: Given the ledger, when it is read, then each covering test is marked native or shell-integration, with the platforms on which it executes and does not skip, and CI shows each executing on those platforms.
- AC4: Given the shell under
packages/agents/source/lib/and the generated skills, then neither changes, andmise run check-generated-skillspasses. - AC5: Non-functional: the pull request stays below 800 lines of code and 2,000 prose lines, and no coverage of still-shipped shell behavior is lost.
Scope and non-goals
Scope: extending the retirement ledger for the allocated group and deleting its residual duplicate cases, including the adapter cases (content posting) that #756 replaces.
Non-goal: the cases before line 260 (the previous child). Non-goal: deleting any shell, the capability probe or the fallback. Non-goal: porting any further behavior. Non-goal: the transaction ports #322 to #327.
Approach
Meet AC1 to AC5. Extend the ledger from the case names still present in the allocated group, then delete. The mechanism is the implementer's choice within those outcomes.
Dependencies
Blocked by: #927 (the early Bats cleanup), #929, #930, #931 (the note, label and signing children of this area), #756, #760, #761, #762, #763, #764, #769, #770, #771 (the ports whose cases are in the group), #753 (golden-file protection for the Go enforcement paths).
Size
S. One pull request, deletions only, with an allocation of at most 709 lines at the baseline.
Verify plan
- AC1: a check that lists the case names in the allocated group and compares each with the ledger.
- AC2:
git diffshows only deletions of ledger-marked cases, the Bats run for the remaining suites passes, and the remaining cases are listed with reasons. - AC3: the ledger columns checked by a script, and the CI job logs for the named Go tests on each promised platform.
- AC4:
git diff --statshows no file outsidetests/skills/source/lib/and the ledger, andmise run check-generated-skillspasses. - AC5: the pull request's size report and the ledger coverage comparison.
- Definition of done: D1 each AC is verified at the merged head, with the commands and results cited in the pull request's Verification. D2 an independent review approves the exact merged head, and every finding has a recorded disposition. D3 required checks pass with no gate loosened. D4 the leak scans the repository specifies are clean, and every post made for this work passes the per-post leak review before it is posted. D5 every commit is signed. D6 the documentation matches the change or the Verification says why there is no impact. D7 every commit has an
Assisted-bytrailer and the pull request has theprovenance:agent-assistedlabel. D8 the pull request stays within the size limits. D9 follow-ups are filed as issues and listed under Related. D10 the merge closes the issue through a closing reference, the board shows Done, and the finalStatus:comment names the merge commit.
Risks
Deleting a case whose Go equivalent is weaker loses coverage; the ledger names each covering test and the review checks it. Undo: revert the change, which restores the cases.
Operator authority
None.
Metadata
Metadata
Assignees
Labels
Type
Fields
Priority
Work type
Projects
- StatusShow more project fieldsBacklog
Activity
tbhb-agent commentedon Oct 27, 2026
Refinement: READY — The residual Bats cases for the review and policy groups are retired
Model: gpt-6-astra
Child 09 The residual Bats cases for the review and policy groups are retired
Verdict: READY
Checked: The renamed body preserves the reviewed 709-line allocation, coverage ledger and prerequisite set; adapter cases remain at
tests/skills/source/lib/lib.bats:820. Gaps: None. Split: None.Definition of done
The definition of done for this issue (Chore). Tick each item and give its evidence.
check-leaks.shwith the repository's private-strings list, and the leak review of each post.docs/, CHANGELOG or help text), or the Verification section says "No doc impact" and why.provenance:agent-assistedlabel.Status:comment names the merge commit.mise run checkis green, and so are the coverage floorsmise run cover-go-checkandmise run cover-py-check, whichcheckdoesn't run.packages/agents/source/commits whatmise run generate-skills, thenmise run skill-tokens, thenapm installrewrite, in that order, andcheck-generated-skills(part oflint) passes.docs/agent-skills-migration.mdor the adoption docs, or the PR's Verification says "No consumer impact" and why.Round: 1 of 3