Skip to content

The residual Bats cases for the review and policy groups are retired #934

Open

Description

@tbhb-agent

Problem

This issue retires the second allocated group of residual cases in tests/skills/source/lib/: the cases of tests/skills/source/lib/lib.bats from line 260 to its end (709 lines at baseline fd7b680): the review, stamp, reviewer-runner, confirmation, trusted policy, quota, runner deadline, adapter, content-posting and verdict-parity cases. They remain only because they exercised shell behavior that the ports under #321 now replace. The first group (gates.bats, masked-status.bats and lib.bats lines 1 to 259) is the previous child. The group is at most 709 lines at the baseline, below both limits whatever the earlier cleanup removed.

Part of #588 and #321. Deletes test cases only; no shell under packages/agents/source/lib/ changes.

Acceptance criteria

  1. AC1: Given every case in the allocated group left after the early cleanup, when the extended retirement ledger is read, then each case names the Go test that covers it, or the reason it is dropped, or the reason it needs a real shell, and no case is unaccounted for.
  2. AC2: Given the merged change, then every case marked deleted is absent, and what remains of lib.bats is listed with a reason for each case; together with the previous child, the three suites are deleted or reduced to cases that need a real shell.
  3. AC3: Given the ledger, when it is read, then each covering test is marked native or shell-integration, with the platforms on which it executes and does not skip, and CI shows each executing on those platforms.
  4. AC4: Given the shell under packages/agents/source/lib/ and the generated skills, then neither changes, and mise run check-generated-skills passes.
  5. AC5: Non-functional: the pull request stays below 800 lines of code and 2,000 prose lines, and no coverage of still-shipped shell behavior is lost.

Scope and non-goals

Scope: extending the retirement ledger for the allocated group and deleting its residual duplicate cases, including the adapter cases (content posting) that #756 replaces.

Non-goal: the cases before line 260 (the previous child). Non-goal: deleting any shell, the capability probe or the fallback. Non-goal: porting any further behavior. Non-goal: the transaction ports #322 to #327.

Approach

Meet AC1 to AC5. Extend the ledger from the case names still present in the allocated group, then delete. The mechanism is the implementer's choice within those outcomes.

Dependencies

Blocked by: #927 (the early Bats cleanup), #929, #930, #931 (the note, label and signing children of this area), #756, #760, #761, #762, #763, #764, #769, #770, #771 (the ports whose cases are in the group), #753 (golden-file protection for the Go enforcement paths).

Size

S. One pull request, deletions only, with an allocation of at most 709 lines at the baseline.

Verify plan

  • AC1: a check that lists the case names in the allocated group and compares each with the ledger.
  • AC2: git diff shows only deletions of ledger-marked cases, the Bats run for the remaining suites passes, and the remaining cases are listed with reasons.
  • AC3: the ledger columns checked by a script, and the CI job logs for the named Go tests on each promised platform.
  • AC4: git diff --stat shows no file outside tests/skills/source/lib/ and the ledger, and mise run check-generated-skills passes.
  • AC5: the pull request's size report and the ledger coverage comparison.
  • Definition of done: D1 each AC is verified at the merged head, with the commands and results cited in the pull request's Verification. D2 an independent review approves the exact merged head, and every finding has a recorded disposition. D3 required checks pass with no gate loosened. D4 the leak scans the repository specifies are clean, and every post made for this work passes the per-post leak review before it is posted. D5 every commit is signed. D6 the documentation matches the change or the Verification says why there is no impact. D7 every commit has an Assisted-by trailer and the pull request has the provenance:agent-assisted label. D8 the pull request stays within the size limits. D9 follow-ups are filed as issues and listed under Related. D10 the merge closes the issue through a closing reference, the board shows Done, and the final Status: comment names the merge commit.

Risks

Deleting a case whose Go equivalent is weaker loses coverage; the ledger names each covering test and the review checks it. Undo: revert the change, which restores the cases.

Operator authority

None.

Activity

  1. tbhb-agent commented on Oct 27, 2026

    @tbhb-agent
    ContributorAuthor

    Refinement: READY — The residual Bats cases for the review and policy groups are retired
    Model: gpt-6-astra

    Child 09 The residual Bats cases for the review and policy groups are retired

    Verdict: READY

    Checked: The renamed body preserves the reviewed 709-line allocation, coverage ledger and prerequisite set; adapter cases remain at tests/skills/source/lib/lib.bats:820. Gaps: None. Split: None.

    Definition of done

    The definition of done for this issue (Chore). Tick each item and give its evidence.

    • D1 The author verified each AC on the merged head, and the Verification section of the pull request cites each AC ID with its evidence: the command and its result, or a link.
    • D2 An independent reviewer approved the exact merged head, and the author resolved each finding or filed it as a follow-up.
    • D3 The required checks pass on that head, and any loosened gate has the owner's approval of that exact head.
    • D4 The leak scans come back clean: gitleaks, devtools' check-leaks.sh with the repository's private-strings list, and the leak review of each post.
    • D5 The author signed each commit, the squash included.
    • D6 The docs match the change (README, docs/, CHANGELOG or help text), or the Verification section says "No doc impact" and why.
    • D7 The commits and the squash have Assisted-by trailers, and the pull request has the provenance:agent-assisted label.
    • D8 The pull request stays within the size limits, or the owner approved its exact head over the hard limit.
    • D9 The author files follow-ups and deferred findings as issues with at least a Problem and numbered AC and lists them under the Related section of the pull request. Any work left in the code links its issue.
    • D10 The merge closes the issue through a closing reference and the board shows Done. The final Status: comment names the merge commit.
    • devtools-1 mise run check is green, and so are the coverage floors mise run cover-go-check and mise run cover-py-check, which check doesn't run.
    • devtools-2 A change to skill sources under packages/agents/source/ commits what mise run generate-skills, then mise run skill-tokens, then apm install rewrite, in that order, and check-generated-skills (part of lint) passes.
    • devtools-3 A consumer-visible change (the vendored payload, a skill, a reusable workflow, a task or a pin) has its consumer steps in docs/agent-skills-migration.md or the adoption docs, or the PR's Verification says "No consumer impact" and why.

    Round: 1 of 3

  2. added theissue type on Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refinement:readyPassed the Definition of Ready; may be picked up

    Type

    Fields

    Priority

    None yet

    Work type

    None yet

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions