Skip to content

Retire rebase Bats cases covered by Go tests #905

Open

Description

@tbhb-agent

Problem

The suites at tests/skills/rebase/scripts/rebase-workflow.bats:7 and tests/skills/rebase/scripts/marker-scan.bats:3 contain 13 cases covering replay evidence and marker dispatch. The scanner already has native and Unix shim tests, but that does not prove every legacy fallback and failure-through-caller case is redundant. Retirement needs a case-by-case ledger after the Go workflow lands.

Part of #588 and #326.

Acceptance criteria

  1. AC1: Given every case in the two suites, when the retirement ledger is read, then each is mapped to a covering Go test or a named reason to retain it.
  2. AC2: Given a deleted case, when its ledger entry is inspected, then it identifies equivalent Go coverage for every still-shipped behavior that case protected.
  3. AC3: Given the retirement diff, when it is inspected, then only ledger-approved duplicate cases and their unused test scaffolding are removed.
  4. AC4: Given a covering test, when its ledger entry is read, then its native or shell-integration coverage kind and executing platforms are stated.
  5. AC5: Given each promised platform, when the covering tests run in CI, then they execute without skips and pass.
  6. AC6: Given frozen fallback behavior without equivalent Go integration coverage, when retirement occurs, then its cases remain.
  7. AC7: Non-functional: retirement changes no executable implementation or compatibility rule.

Scope and non-goals

Scope: the two rebase Bats suites and their retirement ledger, after children 01 to 04 and 10.

Non-goal: adding missing production behavior, deleting fallbacks, rewriting the marker scanner or removing hook tests. Retained fallback cases can be implemented as Go-driven shell integration before retirement; if absent, keep the Bats cases. This child does not wait for N-2 merely to remove proven duplicate tests.

Approach

Start with all seven workflow cases and all six scanner cases. Audit internal/agentrepo/markers_test.go:61, internal/agentrepo/markers_internal_test.go:47 and internal/agentrepo/markers_shim_unix_test.go:38 rather than assuming identical names imply parity. In particular account for missing/old binaries, support probes, stderr-only startup errors and failure propagation through status, continue and verify. Label Unix shell integration honestly; it is not native Windows coverage. Legacy-algorithm cases still lacking Go coverage block children 13 and 14. Finish their separate test retirement here once coverage exists; do not bundle Bats deletion into those production-removal children. Any Bats case retained beyond removal must exercise a surviving shell entry rather than a deleted algorithm.

Dependencies

Blocked by: #895, #896, #897, #898, #904.

Existing scanner coverage is already on main.

Size

S. Forecast 300 code lines: at most 242 measured Bats code lines deleted plus 58 ledger-check/coverage adjustments. Any substantive new Go behavior belongs to a prior child. Prose allowance: 250 lines.

scc could not run in the isolated checkout. Measured baselines count non-blank lines other than full-line # comments, including Python docstrings and embedded code conservatively. Forecasts include implementation, tests, fixtures and registration; they are estimates, not measured future Go. Generated output is excluded only under packages/agents/claude/.apm/skills/, packages/agents/codex/.apm/skills/, .claude/skills/, .agents/skills/ and tokens.json. The source under packages/agents/source/ and copies anywhere else count. The final diff must be at most 800 code lines and 2,000 prose lines, with no exception; split before implementation if either forecast grows beyond its limit.

Verify plan

  • AC1, AC2: enumerate all 13 case names and inspect the assertion-level mapping to existing Go tests.
  • AC3, AC7: inspect the path and content diff; executable implementations and compatibility behavior must be unchanged.
  • AC4, AC5: inspect coverage-kind/platform entries and CI logs proving execution of every promised test.
  • AC6: run remaining Bats cases and Go-driven frozen-fallback cases on their declared shell-capable platforms; compare retained-case list with the ledger.
  • Definition of done: D1 each AC is verified at the merged head, with the commands and results cited in the pull request's Verification. D2 an independent review approves the exact merged head, and every finding has a recorded disposition. D3 required checks pass with no gate loosened. D4 the leak scans the repository specifies are clean, and every post made for this work passes the per-post leak review before it is posted. D5 every commit is signed. D6 the documentation matches the change or the Verification says why there is no impact. D7 every commit has an Assisted-by trailer and the pull request has the provenance:agent-assisted label. D8 the pull request stays within the size limits. D9 follow-ups are filed as issues and listed under Related. D10 the merge closes the issue through a closing reference, the board shows Done, and the final Status: comment names the merge commit.

Risks

Weaker Go assertions can silently lose fallback or failure coverage. Undo: revert the retirement commit to restore the exact Bats cases.

Operator authority

None.

Activity

  1. tbhb-agent commented on Oct 27, 2026

    @tbhb-agent
    ContributorAuthor

    Refinement: READY — Retire rebase Bats cases covered by Go tests
    Model: gpt-6-astra

    Child 11 Retire rebase Bats cases covered by Go tests

    Verdict: READY

    Checked: Prior assertion-level coverage and retained-fallback requirements remain consistent; unaffected by the corrections. Forecast remains 300 lines.

    Gaps: None.

    Split: None required.

    Definition of done

    The definition of done for this issue (Chore). Tick each item and give its evidence.

    • D1 The author verified each AC on the merged head, and the Verification section of the pull request cites each AC ID with its evidence: the command and its result, or a link.
    • D2 An independent reviewer approved the exact merged head, and the author resolved each finding or filed it as a follow-up.
    • D3 The required checks pass on that head, and any loosened gate has the owner's approval of that exact head.
    • D4 The leak scans come back clean: gitleaks, devtools' check-leaks.sh with the repository's private-strings list, and the leak review of each post.
    • D5 The author signed each commit, the squash included.
    • D6 The docs match the change (README, docs/, CHANGELOG or help text), or the Verification section says "No doc impact" and why.
    • D7 The commits and the squash have Assisted-by trailers, and the pull request has the provenance:agent-assisted label.
    • D8 The pull request stays within the size limits, or the owner approved its exact head over the hard limit.
    • D9 The author files follow-ups and deferred findings as issues with at least a Problem and numbered AC and lists them under the Related section of the pull request. Any work left in the code links its issue.
    • D10 The merge closes the issue through a closing reference and the board shows Done. The final Status: comment names the merge commit.
    • devtools-1 mise run check is green, and so are the coverage floors mise run cover-go-check and mise run cover-py-check, which check doesn't run.
    • devtools-2 A change to skill sources under packages/agents/source/ commits what mise run generate-skills, then mise run skill-tokens, then apm install rewrite, in that order, and check-generated-skills (part of lint) passes.
    • devtools-3 A consumer-visible change (the vendored payload, a skill, a reusable workflow, a task or a pin) has its consumer steps in docs/agent-skills-migration.md or the adoption docs, or the PR's Verification says "No consumer impact" and why.

    Round: 2 of 3

  2. added theissue type on Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refinement:readyPassed the Definition of Ready; may be picked up

    Type

    Fields

    Priority

    None yet

    Work type

    None yet

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions