Skip to content

Resolve one path by an explicit side in Go #903

Description

@tbhb-agent

Problem

The side picker at packages/agents/source/skills/resolve-rebase-conflicts/shared/scripts/take-side.sh:51 uses base-side and replayed-side because Git's ours/theirs wording is reversed during replay. An absent chosen stage means deletion, not an empty file. Generated-file advice also has to survive the port.

Part of #588 and #326.

Acceptance criteria

  1. AC1: Given missing or invalid arguments, when a side is requested, then the frozen refusal is returned.
  2. AC2: Given ours or theirs as the side name, when resolution is requested, then it refuses the ambiguous name.
  3. AC3: Given no supported active operation or a path that is not unmerged, when resolution is requested, then it refuses before changing the path.
  4. AC4: Given a present selected stage, when base-side or replayed-side is chosen, then the path receives exactly the selected stage's bytes.
  5. AC5: Given an absent selected stage, when that side is chosen, then the path is deleted and the deletion is staged.
  6. AC6: Given a present selected stage, when resolution succeeds, then only the named path is staged.
  7. AC7: Given a side choice, when resolution starts, then the frozen commit and stage explanation is printed before changing the path.
  8. AC8: Given a regeneration declaration on a retained path, when resolution succeeds, then the frozen placeholder warning is printed.
  9. AC9: Non-functional: choosing a side never continues the replay or runs a generator.
  10. AC10: Non-functional: native side-choice cases execute without skips on macOS, Linux and Windows.

Scope and non-goals

Scope: explicit side choice and named staging under agentrepo rebase.

Non-goal: deciding which intent wins, automatic token application, generating files or changing PreToolUse policy. Keep shell and coupled Python frozen through N-2, with no new shell logic. Do not switch callers or retire tests in this child.

Approach

Preserve argument mapping at packages/agents/source/skills/resolve-rebase-conflicts/shared/scripts/take-side.sh:56 and deletion handling at packages/agents/source/skills/resolve-rebase-conflicts/shared/scripts/take-side.sh:90. Exercise merge/apply rebases and cherry-picks. Test binary stage bytes as well as ordinary text. Use the existing operation context and direct Git stage reads; no marker parsing is needed.

Dependencies

Blocked by: #753.

Prerequisite: #321's repository-context deliverable.

Size

S. Forecast 430 code lines: 160 implementation, 230 tests and fixtures, 40 integration. Measured source baseline: 67 code lines. Prose allowance: 160 lines.

scc could not run in the isolated checkout. Measured baselines count non-blank lines other than full-line # comments, including Python docstrings and embedded code conservatively. Forecasts include implementation, tests, fixtures and registration; they are estimates, not measured future Go. Generated output is excluded only under packages/agents/claude/.apm/skills/, packages/agents/codex/.apm/skills/, .claude/skills/, .agents/skills/ and tokens.json. The source under packages/agents/source/ and copies anywhere else count. The final diff must be at most 800 code lines and 2,000 prose lines, with no exception; split before implementation if either forecast grows beyond its limit.

Verify plan

  • AC1, AC2, AC3: compare invalid arguments, inverted words, unsupported operations and resolved-path refusals with the frozen script.
  • AC4, AC5, AC6: inspect worktree bytes and index for both stages, binary input and both delete/modify directions; unrelated paths remain unchanged.
  • AC7, AC8: compare ordering and content of explanation and regeneration warnings.
  • AC9: inspect the command trace for absence of continuation and generator calls.
  • AC10: inspect executing native cases on macOS, Linux and Windows.
  • Definition of done: D1 each AC is verified at the merged head, with the commands and results cited in the pull request's Verification. D2 an independent review approves the exact merged head, and every finding has a recorded disposition. D3 required checks pass with no gate loosened. D4 the leak scans the repository specifies are clean, and every post made for this work passes the per-post leak review before it is posted. D5 every commit is signed. D6 the documentation matches the change or the Verification says why there is no impact. D7 every commit has an Assisted-by trailer and the pull request has the provenance:agent-assisted label. D8 the pull request stays within the size limits. D9 follow-ups are filed as issues and listed under Related. D10 the merge closes the issue through a closing reference, the board shows Done, and the final Status: comment names the merge commit.

Risks

An inverted mapping can silently discard the intended side. Treating a missing stage as empty would erase deletion intent. Undo: revert the port; preserve conflict-stage evidence rather than attempting an automatic opposite-side rewrite.

Operator authority

None.

Activity

  1. tbhb-agent commented on Oct 27, 2026

    @tbhb-agent
    ContributorAuthor

    Refinement: READY — Resolve one path by an explicit side in Go
    Model: gpt-6-astra

    Child 09 Resolve one path by an explicit side in Go

    Verdict: READY

    Checked: Prior explicit-side, deletion and exact-byte contracts remain consistent; unaffected by the corrections. Forecast remains 430 lines.

    Gaps: None.

    Split: None required.

    Definition of done

    The definition of done for this issue (Feature). Tick each item and give its evidence.

    • D1 The author verified each AC on the merged head, and the Verification section of the pull request cites each AC ID with its evidence: the command and its result, or a link.
    • D2 An independent reviewer approved the exact merged head, and the author resolved each finding or filed it as a follow-up.
    • D3 The required checks pass on that head, and any loosened gate has the owner's approval of that exact head.
    • D4 The leak scans come back clean: gitleaks, devtools' check-leaks.sh with the repository's private-strings list, and the leak review of each post.
    • D5 The author signed each commit, the squash included.
    • D6 The docs match the change (README, docs/, CHANGELOG or help text), or the Verification section says "No doc impact" and why.
    • D7 The commits and the squash have Assisted-by trailers, and the pull request has the provenance:agent-assisted label.
    • D8 The pull request stays within the size limits, or the owner approved its exact head over the hard limit.
    • D9 The author files follow-ups and deferred findings as issues with at least a Problem and numbered AC and lists them under the Related section of the pull request. Any work left in the code links its issue.
    • D10 The merge closes the issue through a closing reference and the board shows Done. The final Status: comment names the merge commit.
    • devtools-1 mise run check is green, and so are the coverage floors mise run cover-go-check and mise run cover-py-check, which check doesn't run.
    • devtools-2 A change to skill sources under packages/agents/source/ commits what mise run generate-skills, then mise run skill-tokens, then apm install rewrite, in that order, and check-generated-skills (part of lint) passes.
    • devtools-3 A consumer-visible change (the vendored payload, a skill, a reusable workflow, a task or a pin) has its consumer steps in docs/agent-skills-migration.md or the adoption docs, or the PR's Verification says "No consumer impact" and why.

    Round: 2 of 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refinement:readyPassed the Definition of Ready; may be picked up

    Fields

    Priority

    None yet

    Work type

    None yet

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions