Repository navigation
Description
Problem
populate-description.sh (108 lines) rebuilds PR_AGENTDESC.md from a published pull request when the draft is gone: frontmatter for base, draft state, labels, reviewers, assignees and milestone, the title and the body. Its core is an inline python3 program, so it needs a Python the toolchain otherwise avoids, and it is under the shell freeze in #588. The title is written exactly as GitHub holds it with surrounding whitespace trimmed; the program does not remove a trailing (#<number>), although the script's closing message says it does.
Part of #324, within #588. Child 13 in #324's Children list. Replaces packages/agents/source/skills/merge-pr/shared/scripts/populate-description.sh.
Acceptance criteria
- AC1: Given an open pull request and no draft, when
agentrepo merge descriptionruns, thenPR_AGENTDESC.mdholdsbase,draft,labels,reviewers: [],assigneesandmilestonefrontmatter, a# <title>heading and the body with carriage returns normalized, byte for byte as the shell script wrote them. - AC2: Given a pull request whose title ends in
(#<number>), when it runs, then the heading carries the title unchanged apart from trimmed surrounding whitespace, suffix included. - AC3: Given a draft that already has content and no
--force, when it runs, then it leaves the file alone, says so and exits 0; given--force, then it replaces it. - AC4: Given no number and no open pull request for the current branch, when it runs, then it exits 1 asking for a number.
- AC5: Given
ghis missing or not authenticated, or the pull request cannot be read, when it runs, then it exits 1 with the shell script's message and writes nothing. - AC6: Given a pull request with no labels, assignees or milestone, when it runs, then the empty lists and the empty
milestone:key match the shell output. - AC7: Non-functional: it needs no Python, and runs on macOS, Linux and Windows in CI.
Scope and non-goals
Scope: agentrepo merge description and its tests.
Non-goal: validating the description, which lint-pr-description and the pr workflow own. Non-goal: correcting the closing message about the suffix; it is kept as the shell prints it and any change is a follow-up issue. Non-goal: editing the shell script before child 14.
Approach
Meet AC1 to AC7 with failing cases first: golden draft files from the shell script on fake-gh fixtures, including a suffixed title, then Go compared byte for byte. Mechanism is the implementer's choice.
Dependencies
Blocked by: #333.
Prerequisites: #321 GitHub reader and #333.
Size
S. One pull request.
Verify plan
- AC1, AC2, AC6: golden-file comparison, one fixture with a
(#<number>)suffixed title. - AC3, AC4, AC5: table-driven cases with a fake
gh. - AC7: a test with Python absent from PATH; the CI matrix run.
- Definition of done: D1 each AC is verified at the merged head, with the commands and results cited in the pull request's Verification. D2 an independent review approves the exact merged head, and every finding has a recorded disposition. D3 required checks pass with no gate loosened. D4 the leak scans the repository specifies are clean, and every post made for this work passes the per-post leak review before it is posted. D5 every commit is signed. D6 the documentation matches the change or the Verification says why there is no impact. D7 every commit has an
Assisted-bytrailer and the pull request has theprovenance:agent-assistedlabel. D8 the pull request stays within the size limits. D9 follow-ups are filed as issues and listed under Related. D10 the merge closes the issue through a closing reference, the board shows Done, and the finalStatus:comment names the merge commit.
Risks
A changed draft layout could fail the description validator later; golden comparison is the control. Undo: revert; the shell script is untouched.
Operator authority
None.
Metadata
Metadata
Assignees
Labels
Type
Fields
Priority
Work type
Projects
- StatusShow more project fieldsBacklog
Activity
tbhb-agent commentedon Oct 27, 2026
Refinement: READY — A pull request description draft is rebuilt from the published pull request in Go
Model: gpt-6-astra
Child 13 A pull request description draft is rebuilt from the published pull request in Go
Verdict: READY
Checked: Title preservation, existing-draft protection, error handling and Python removal remain bounded and verifiable. The suffixed-title contract matches
packages/agents/source/skills/merge-pr/shared/scripts/populate-description.sh:84andpackages/agents/source/skills/merge-pr/shared/scripts/populate-description.sh:100. No regression from the round 2 body was identified.Gaps: None.
Split: None needed.
Definition of done
The definition of done for this issue (Feature). Tick each item and give its evidence.
check-leaks.shwith the repository's private-strings list, and the leak review of each post.docs/, CHANGELOG or help text), or the Verification section says "No doc impact" and why.provenance:agent-assistedlabel.Status:comment names the merge commit.mise run checkis green, and so are the coverage floorsmise run cover-go-checkandmise run cover-py-check, whichcheckdoesn't run.packages/agents/source/commits whatmise run generate-skills, thenmise run skill-tokens, thenapm installrewrite, in that order, andcheck-generated-skills(part oflint) passes.docs/agent-skills-migration.mdor the adoption docs, or the PR's Verification says "No consumer impact" and why.Round: 3 of 3