Move watch-pr and fix-pr scripts into agentrepo checks #325

Activity

1. tbhb-agent

   added

   change:featPR adds or changes a feature (Conventional Commit type feat)PR adds or changes a feature (Conventional Commit type feat)

   on Oct 20, 2026
2. github-project-automation

   added this to devtoolson Oct 20, 2026
3. github-project-automation

   moved this to Backlog in devtoolson Oct 20, 2026
4. tbhb-agent

   added a parent issue on Oct 20, 2026

   • Evaluate every Bash script and bats suite: port to Go or Python, or optimize, with a 200 SLOC limit #203
5. tbhb-agent

   added the

   Feature

   issue type on Oct 22, 2026
6. tbhb-agent

   removed

   change:featPR adds or changes a feature (Conventional Commit type feat)PR adds or changes a feature (Conventional Commit type feat)

   on Oct 22, 2026
7. tbhb-agent

   removed a parent issue on Oct 23, 2026

   • Evaluate every Bash script and bats suite: port to Go or Python, or optimize, with a 200 SLOC limit #203
8. tbhb-agent

   added a parent issue on Oct 23, 2026

   • Replace complex shell with tested Go, starting with gates and merging #588
9. tbhb-dev-agent-projects

   set

   Priority

   to

   Intangible

   on Oct 23, 2026
10. tbhb-agent

    set

    Work type

    to

    Planned

    on Oct 25, 2026
11. tbhb-agent

    added sub-issues on Oct 26, 2026

    • feat(checks): move pull request watching into Go #793
    • feat(checks): move pull request failure diagnosis into Go #794
    • feat(pr): move shared description restoration into Go #795
12. tbhb-agent

    added

    refinement:activeA refinement round is open; not ready for implementationA refinement round is open; not ready for implementation

    on Oct 31, 2026
13. tbhb-dev-reviews commented on Oct 31, 2026

    

    tbhb-dev-reviewsBot

    on Oct 31, 2026

    More actions

    Refinement: NOT READY — restoration overlaps the merge epic, and the live type is still Feature

    Checked

    • Read Move watch-pr and fix-pr scripts into agentrepo checks #325, parent Replace complex shell with tested Go, starting with gates and merging #588, sibling scopes Port the shared skill library (lib.sh, agent.sh, signing.sh, gates.py) to Go #321/Move the pr, write-pr-description and agent-pr scripts into agentrepo pr #323/Move the merge-pr, merge policy and agent-merge-pr scripts into agentrepo merge #324/Replace the Claude guard-hook scripts with standalone guard binaries #328/Ship the Go binaries as release assets installed through mise's github backend #333, children feat(checks): move pull request watching into Go #793/feat(checks): move pull request failure diagnosis into Go #794/feat(pr): move shared description restoration into Go #795 and watching splits feat(checks): add the Go pull request watch command #976/feat(checks): route the watch wrapper to the Go command #977/test(checks): prove watch command parity against the pinned shell #978. All children exist: feat(checks): move pull request watching into Go #793 is Epic, feat(checks): move pull request failure diagnosis into Go #794/feat(pr): move shared description restoration into Go #795 are Features. Required Epic headings are present.
    • Verified origin/main 591fd70 matches remote main. Diagnosis shipped in merged feat(checks): diagnose failures in Go #832/test(checks): verify diagnosis report parity #959/feat(checks): route diagnosis through the Go command #960: internal/agentrepo/command.go:84 registers it, internal/agentrepo/diagnose.go:23 implements it, packages/agents/source/skills/fix-pr/shared/scripts/diagnose.sh:5 forwards it, and tests/skills/fix-pr/scripts/diagnose.bats:40 covers dispatch.
    • Watching and restoration remain unfinished on main. internal/agentrepo/command.go:84 registers evaluation and diagnosis, with no watch or pr command. The two populate-description scripts are byte-identical.
    • Read open watcher PRs feat(checks): watch pull requests in Go #824/feat(checks): watch pull requests in Go #961/feat(checks): route the watcher through Go with fallback #962, diagnosis PR feat(checks): route diagnosis through the Go command #939 and restoration overlaps fix(fix-pr): make unattended repair paths deterministic #349/fix(fix-pr): make unattended repair paths deterministic #696. The full epic is not delivered. feat(pr): move shared description restoration into Go #795 dispositions fix(fix-pr): make unattended repair paths deterministic #349/fix(fix-pr): make unattended repair paths deterministic #696 and defers their behavior changes to Go. feat(checks): route diagnosis through the Go command #939 duplicates the diagnosis route already merged in feat(checks): route diagnosis through the Go command #960.
    • Accepted the supplied mechanical pass without rerunning it. Ran bin/request dod Move watch-pr and fix-pr scripts into agentrepo checks #325 --type Epic. No test suite was run.
    • Round-1 comparison is unavailable: GraphQL reports zero comments and REST returns an empty comments list for Move watch-pr and fix-pr scripts into agentrepo checks #325. Restore or link the previous Refinement verdict so each earlier Gaps/Split item can be audited. This review does not assert unseen findings were resolved.

    Gaps

    1. GitHub still types Move watch-pr and fix-pr scripts into agentrepo checks #325 as Feature, despite its L epic body, children and explicit absence of a single implementation PR. Change the actual type to Epic.
    2. Restoration has conflicting owners. feat(pr): move shared description restoration into Go #795 owns agentrepo pr populate-description and both wrappers; sibling Move the merge-pr, merge policy and agent-merge-pr scripts into agentrepo merge #324 child A pull request description draft is rebuilt from the published pull request in Go #873 separately owns agentrepo merge description, and The lint, populate-description, squash-message and review scripts become wrappers over agentrepo merge #874 AC1 owns the merge-pr restoration wrapper. A pull request description draft is rebuilt from the published pull request in Go #873 preserves misleading suffix guidance that feat(pr): move shared description restoration into Go #795 AC9 fixes. Assign ownership once, update A pull request description draft is rebuilt from the published pull request in Go #873/The lint, populate-description, squash-message and review scripts become wrappers over agentrepo merge #874 and Move the merge-pr, merge policy and agent-merge-pr scripts into agentrepo merge #324 to consume the shared result, and record the boundary in Move watch-pr and fix-pr scripts into agentrepo checks #325. The identical scripts on main verify this is the same behavior.
    3. Outcome and Done when 1 promise an unchanged watcher contract, but test(checks): prove watch command parity against the pinned shell #978 AC3 and feat(checks): watch pull requests in Go #961 explicitly permit nonempty-then-empty snapshots to TIMEOUT with status 2 instead of shell ALL GREEN. Main verifies the difference: packages/agents/source/skills/watch-pr/shared/scripts/watch-checks.sh:165 breaks when pending is zero, then :181 reports green with zero failures. State the safety exception and its evidence in Move watch-pr and fix-pr scripts into agentrepo checks #325; reconcile unchanged-contract wording in feat(checks): move pull request watching into Go #793/feat(checks): add the Go pull request watch command #976 with test(checks): prove watch command parity against the pinned shell #978.
    4. Add the Epic's own D4 verification and an evidence-bearing closing comment to Done when. Child closure alone does not cover scans for this epic's text/posts or epic-2. Correct Children too: feat(pr): move shared description restoration into Go #795 now declares M, not S.

    Split

    Keep watching / delivered diagnosis / shared restoration. No further implementation split is needed for #325 itself. Resolve the duplicate restoration allocation in #873/#874 before coding. Use existing #961/#962 and #978 parity work for watching, with an explicit disposition of superseded #824; do not start another implementation. Diagnosis is complete.

    Definition of done

    Ticks mean child ACs/Verify plans cover the requirement, not that unfinished delivery checks passed. The requested Epic checklist contains D4, epic-1 and epic-2; other base items apply to child PRs.

    • D1 Child plans require merged-head AC evidence in PR Verification.
    • D2 Child plans require independent exact-head approval and finding disposition.
    • D3 Child plans require passing checks and approval of gate loosening.
    • D4 The leak scans come back clean: gitleaks, devtools' check-leaks.sh with the repository's private-strings list, and the leak review of each post. Child plans cover these; Move watch-pr and fix-pr scripts into agentrepo checks #325 needs its own verification obligation.
    • D5 Child plans require signed commits and squash.
    • D6 Child plans require matching docs and migration guidance.
    • D7 Child plans require Assisted-by trailers and provenance:agent-assisted.
    • D8 Child plans require size checks; feat(pr): move shared description restoration into Go #795 provides a split contingency.
    • D9 Child plans require follow-up issues, numbered ACs and Related links.
    • D10 Child plans require closing references, Done board state and final Status naming the merge.
    • epic-1 Each child issue has closed, or closed as not planned with a reason. feat(checks): move pull request watching into Go #793/feat(pr): move shared description restoration into Go #795 remain open; Done when names their closure evidence.
    • epic-2 A closing comment checks its "Done when" with evidence. Add this obligation to Move watch-pr and fix-pr scripts into agentrepo checks #325.

    Round: 2 of 3
14. tbhb-agent

    changed the issue type from

    Feature

    to

    Epic

    on Oct 31, 2026
15. tbhb-agent

    marked this as blocking on Oct 31, 2026

    • Remove the frozen watch-pr shell callers after the N-2 window #1007